From 91ac912b2f63868a91a52744232b19b85950a0fa Mon Sep 17 00:00:00 2001 From: David Brown Date: Tue, 12 Mar 2013 11:41:51 -0700 Subject: [PATCH] --- yaml --- r: 363128 b: refs/heads/master c: 3f7a73b57c2f57aa25342ebdb7312f78c68502eb h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/drivers/ssbi/ssbi.c | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/[refs] b/[refs] index 8e8ea51cb090..f0fe136959d6 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 97f00f7120fe3396302693cdc4b1d11bbacad963 +refs/heads/master: 3f7a73b57c2f57aa25342ebdb7312f78c68502eb diff --git a/trunk/drivers/ssbi/ssbi.c b/trunk/drivers/ssbi/ssbi.c index 6fbcb25907ff..7ae892590c75 100644 --- a/trunk/drivers/ssbi/ssbi.c +++ b/trunk/drivers/ssbi/ssbi.c @@ -87,6 +87,15 @@ static inline void ssbi_writel(struct msm_ssbi *ssbi, u32 val, u32 reg) writel(val, ssbi->base + reg); } +/* + * Via private exchange with one of the original authors, the hardware + * should generally finish a transaction in about 5us. The worst + * case, is when using the arbiter and both other CPUs have just + * started trying to use the SSBI bus will result in a time of about + * 20us. It should never take longer than this. + * + * As such, this wait merely spins, with a udelay. + */ static int ssbi_wait_mask(struct msm_ssbi *ssbi, u32 set_mask, u32 clr_mask) { u32 timeout = SSBI_TIMEOUT_US; @@ -161,6 +170,10 @@ msm_ssbi_write_bytes(struct msm_ssbi *ssbi, u16 addr, u8 *buf, int len) return ret; } +/* + * See ssbi_wait_mask for an explanation of the time and the + * busywait. + */ static inline int msm_ssbi_pa_transfer(struct msm_ssbi *ssbi, u32 cmd, u8 *data) {