From 971795ed5a4d35c3bafe0bd484f47aad9b36cb8d Mon Sep 17 00:00:00 2001 From: Dylan Reid Date: Fri, 28 Sep 2012 15:57:01 -0700 Subject: [PATCH] --- yaml --- r: 332185 b: refs/heads/master c: d17344b3547669f5b6ee4fda993d03737a141bd6 h: refs/heads/master i: 332183: cf9f58d8f0908c2d8ea8877579bd16960361a117 v: v3 --- [refs] | 2 +- trunk/sound/pci/hda/hda_codec.c | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/[refs] b/[refs] index 186882bdf342..808a2bb9981f 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 395d9dd5dd13c6aa3c8c61a31126af98cd1e747d +refs/heads/master: d17344b3547669f5b6ee4fda993d03737a141bd6 diff --git a/trunk/sound/pci/hda/hda_codec.c b/trunk/sound/pci/hda/hda_codec.c index 960800b862ab..c0ab72cbeed1 100644 --- a/trunk/sound/pci/hda/hda_codec.c +++ b/trunk/sound/pci/hda/hda_codec.c @@ -3612,7 +3612,7 @@ static inline void hda_exec_init_verbs(struct hda_codec *codec) {} * call suspend and power-down; used both from PM and power-save * this function returns the power state in the end */ -static unsigned int hda_call_codec_suspend(struct hda_codec *codec) +static unsigned int hda_call_codec_suspend(struct hda_codec *codec, bool in_wq) { unsigned int state; @@ -3620,7 +3620,9 @@ static unsigned int hda_call_codec_suspend(struct hda_codec *codec) codec->patch_ops.suspend(codec); hda_cleanup_all_streams(codec); state = hda_set_power_state(codec, AC_PWRST_D3); - cancel_delayed_work(&codec->power_work); + /* Cancel delayed work if we aren't currently running from it. */ + if (!in_wq) + cancel_delayed_work_sync(&codec->power_work); spin_lock(&codec->power_lock); snd_hda_update_power_acct(codec); trace_hda_power_down(codec); @@ -4478,7 +4480,7 @@ static void hda_power_work(struct work_struct *work) } spin_unlock(&codec->power_lock); - state = hda_call_codec_suspend(codec); + state = hda_call_codec_suspend(codec, true); codec->pm_down_notified = 0; if (!bus->power_keep_link_on && (state & AC_PWRST_CLK_STOP_OK)) { codec->pm_down_notified = 1; @@ -5127,7 +5129,7 @@ int snd_hda_suspend(struct hda_bus *bus) list_for_each_entry(codec, &bus->codec_list, list) { if (hda_codec_is_power_on(codec)) - hda_call_codec_suspend(codec); + hda_call_codec_suspend(codec, false); } return 0; }