From 9b00142e6e8783e828a0b77e418edfd4115f61d9 Mon Sep 17 00:00:00 2001 From: Valentine Barshak Date: Thu, 3 Apr 2008 23:09:43 +0400 Subject: [PATCH] --- yaml --- r: 91541 b: refs/heads/master c: 7132799b0e49c48cf119dbe02d20810860d20991 h: refs/heads/master i: 91539: f587eb17c640fcc81c5ec79750537cced50701aa v: v3 --- [refs] | 2 +- trunk/arch/powerpc/sysdev/mpic.c | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/[refs] b/[refs] index e5e656e1f7fd..e9cb7ba617f5 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: f724bf77813d73318bf97dab9626156a0a87c7fc +refs/heads/master: 7132799b0e49c48cf119dbe02d20810860d20991 diff --git a/trunk/arch/powerpc/sysdev/mpic.c b/trunk/arch/powerpc/sysdev/mpic.c index 6131fd2b6619..8619f2a3f1f6 100644 --- a/trunk/arch/powerpc/sysdev/mpic.c +++ b/trunk/arch/powerpc/sysdev/mpic.c @@ -1410,11 +1410,6 @@ void mpic_cpu_set_priority(int prio) mpic_cpu_write(MPIC_INFO(CPU_CURRENT_TASK_PRI), prio); } -/* - * XXX: someone who knows mpic should check this. - * do we need to eoi the ipi including for kexec cpu here (see xics comments)? - * or can we reset the mpic in the new kernel? - */ void mpic_teardown_this_cpu(int secondary) { struct mpic *mpic = mpic_primary; @@ -1434,6 +1429,10 @@ void mpic_teardown_this_cpu(int secondary) /* Set current processor priority to max */ mpic_cpu_write(MPIC_INFO(CPU_CURRENT_TASK_PRI), 0xf); + /* We need to EOI the IPI since not all platforms reset the MPIC + * on boot and new interrupts wouldn't get delivered otherwise. + */ + mpic_eoi(mpic); spin_unlock_irqrestore(&mpic_lock, flags); }