From 9bce928e647f24cc1f1620dfb44d7411d9649489 Mon Sep 17 00:00:00 2001 From: Eric Sesterhenn Date: Sun, 26 Mar 2006 18:26:51 +0200 Subject: [PATCH] --- yaml --- r: 24210 b: refs/heads/master c: 4d4ef9abe34a472fbfc9ab75cfde0d58bc342c44 h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/fs/hfs/bnode.c | 9 +++------ trunk/fs/hfs/btree.c | 3 +-- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/[refs] b/[refs] index 76015db2330d..3930be177b85 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 28133c7b2b9bbdf8a8765a319e818c1652f38c1f +refs/heads/master: 4d4ef9abe34a472fbfc9ab75cfde0d58bc342c44 diff --git a/trunk/fs/hfs/bnode.c b/trunk/fs/hfs/bnode.c index a7a7d77f3fd3..1e44dcfe49c4 100644 --- a/trunk/fs/hfs/bnode.c +++ b/trunk/fs/hfs/bnode.c @@ -306,8 +306,7 @@ void hfs_bnode_unhash(struct hfs_bnode *node) for (p = &node->tree->node_hash[hfs_bnode_hash(node->this)]; *p && *p != node; p = &(*p)->next_hash) ; - if (!*p) - BUG(); + BUG_ON(!*p); *p = node->next_hash; node->tree->node_hash_cnt--; } @@ -415,8 +414,7 @@ struct hfs_bnode *hfs_bnode_create(struct hfs_btree *tree, u32 num) spin_lock(&tree->hash_lock); node = hfs_bnode_findhash(tree, num); spin_unlock(&tree->hash_lock); - if (node) - BUG(); + BUG_ON(node); node = __hfs_bnode_create(tree, num); if (!node) return ERR_PTR(-ENOMEM); @@ -459,8 +457,7 @@ void hfs_bnode_put(struct hfs_bnode *node) dprint(DBG_BNODE_REFS, "put_node(%d:%d): %d\n", node->tree->cnid, node->this, atomic_read(&node->refcnt)); - if (!atomic_read(&node->refcnt)) - BUG(); + BUG_ON(!atomic_read(&node->refcnt)); if (!atomic_dec_and_lock(&node->refcnt, &tree->hash_lock)) return; for (i = 0; i < tree->pages_per_bnode; i++) { diff --git a/trunk/fs/hfs/btree.c b/trunk/fs/hfs/btree.c index 7bb11edd1488..d20131ce4b95 100644 --- a/trunk/fs/hfs/btree.c +++ b/trunk/fs/hfs/btree.c @@ -36,8 +36,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp ke tree->inode = iget_locked(sb, id); if (!tree->inode) goto free_tree; - if (!(tree->inode->i_state & I_NEW)) - BUG(); + BUG_ON(!(tree->inode->i_state & I_NEW)); { struct hfs_mdb *mdb = HFS_SB(sb)->mdb; HFS_I(tree->inode)->flags = 0;