From 9c591297a4831139ba6111ec022454882c0dac3a Mon Sep 17 00:00:00 2001 From: Ian Abbott Date: Thu, 4 Apr 2013 14:58:47 +0100 Subject: [PATCH] --- yaml --- r: 363900 b: refs/heads/master c: 3346b798f202bf2f5b5272870ecdb75acec2e752 h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/drivers/staging/comedi/comedi_fops.c | 7 ++++--- trunk/drivers/staging/comedi/comedi_internal.h | 2 +- trunk/drivers/staging/comedi/drivers.c | 7 +------ 4 files changed, 7 insertions(+), 11 deletions(-) diff --git a/[refs] b/[refs] index 1f3fa5d4a49c..f292ea8fd802 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 24fb134d1c336b263f75d7659f56a96382aebb56 +refs/heads/master: 3346b798f202bf2f5b5272870ecdb75acec2e752 diff --git a/trunk/drivers/staging/comedi/comedi_fops.c b/trunk/drivers/staging/comedi/comedi_fops.c index 8b5fa2fc9a82..ce050e4ba107 100644 --- a/trunk/drivers/staging/comedi/comedi_fops.c +++ b/trunk/drivers/staging/comedi/comedi_fops.c @@ -2348,7 +2348,7 @@ void comedi_free_board_minor(unsigned minor) comedi_free_board_file_info(comedi_clear_minor(minor)); } -int comedi_find_board_minor(struct device *hardware_device) +void comedi_release_hardware_device(struct device *hardware_device) { int minor; struct comedi_file_info *info; @@ -2357,12 +2357,13 @@ int comedi_find_board_minor(struct device *hardware_device) spin_lock(&comedi_file_info_table_lock); info = comedi_file_info_table[minor]; if (info && info->hardware_device == hardware_device) { + comedi_file_info_table[minor] = NULL; spin_unlock(&comedi_file_info_table_lock); - return minor; + comedi_free_board_file_info(info); + break; } spin_unlock(&comedi_file_info_table_lock); } - return -ENODEV; } int comedi_alloc_subdevice_minor(struct comedi_subdevice *s) diff --git a/trunk/drivers/staging/comedi/comedi_internal.h b/trunk/drivers/staging/comedi/comedi_internal.h index b3743135f4aa..fd14de662e8f 100644 --- a/trunk/drivers/staging/comedi/comedi_internal.h +++ b/trunk/drivers/staging/comedi/comedi_internal.h @@ -10,7 +10,7 @@ int do_rangeinfo_ioctl(struct comedi_device *dev, struct comedi_rangeinfo __user *arg); int comedi_alloc_board_minor(struct device *hardware_device); void comedi_free_board_minor(unsigned minor); -int comedi_find_board_minor(struct device *hardware_device); +void comedi_release_hardware_device(struct device *hardware_device); int comedi_alloc_subdevice_minor(struct comedi_subdevice *s); void comedi_free_subdevice_minor(struct comedi_subdevice *s); diff --git a/trunk/drivers/staging/comedi/drivers.c b/trunk/drivers/staging/comedi/drivers.c index 4460814d5344..29c8f5037065 100644 --- a/trunk/drivers/staging/comedi/drivers.c +++ b/trunk/drivers/staging/comedi/drivers.c @@ -459,14 +459,9 @@ EXPORT_SYMBOL_GPL(comedi_auto_config); void comedi_auto_unconfig(struct device *hardware_device) { - int minor; - if (hardware_device == NULL) return; - minor = comedi_find_board_minor(hardware_device); - if (minor < 0) - return; - comedi_free_board_minor(minor); + comedi_release_hardware_device(hardware_device); } EXPORT_SYMBOL_GPL(comedi_auto_unconfig);