From 9c8e0a95990613a0514a8fffc1e9c4d45fde00d0 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Fri, 2 Jul 2010 16:34:01 +0000 Subject: [PATCH] --- yaml --- r: 200883 b: refs/heads/master c: 58eba97d0774c69b1cf3e5a8ac74419409d1abbf h: refs/heads/master i: 200881: 96c7eb591ef65c8a06d7742be843ac60030e0283 200879: 1d6de3350d85b0245d6b388478c789bcc9e93512 v: v3 --- [refs] | 2 +- trunk/drivers/net/virtio_net.c | 21 +++++++++++++-------- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/[refs] b/[refs] index bfe11ddf6706..4372426d4be6 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 1788f49548860fa1c861ee3454d47b466c877e43 +refs/heads/master: 58eba97d0774c69b1cf3e5a8ac74419409d1abbf diff --git a/trunk/drivers/net/virtio_net.c b/trunk/drivers/net/virtio_net.c index ee7571195b10..bb6b67f6b0cc 100644 --- a/trunk/drivers/net/virtio_net.c +++ b/trunk/drivers/net/virtio_net.c @@ -562,7 +562,6 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev) struct virtnet_info *vi = netdev_priv(dev); int capacity; -again: /* Free up any pending old buffers before queueing new ones. */ free_old_xmit_skbs(vi); @@ -571,14 +570,20 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev) /* This can happen with OOM and indirect buffers. */ if (unlikely(capacity < 0)) { - netif_stop_queue(dev); - dev_warn(&dev->dev, "Unexpected full queue\n"); - if (unlikely(!virtqueue_enable_cb(vi->svq))) { - virtqueue_disable_cb(vi->svq); - netif_start_queue(dev); - goto again; + if (net_ratelimit()) { + if (likely(capacity == -ENOMEM)) { + dev_warn(&dev->dev, + "TX queue failure: out of memory\n"); + } else { + dev->stats.tx_fifo_errors++; + dev_warn(&dev->dev, + "Unexpected TX queue failure: %d\n", + capacity); + } } - return NETDEV_TX_BUSY; + dev->stats.tx_dropped++; + kfree_skb(skb); + return NETDEV_TX_OK; } virtqueue_kick(vi->svq);