From b01beb79f170029f4d29cb6678547283e9b93c99 Mon Sep 17 00:00:00 2001 From: Frederic Weisbecker Date: Fri, 9 Oct 2009 20:31:02 +0200 Subject: [PATCH] --- yaml --- r: 173194 b: refs/heads/master c: 205153aa40b7fb36dc7fe76c1798584ace55b288 h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/drivers/char/mem.c | 17 +++++------------ 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/[refs] b/[refs] index 373b61278735..af224ff28b36 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 4c2aedc2543248c3fdc8c06c662b589d36c93bbb +refs/heads/master: 205153aa40b7fb36dc7fe76c1798584ace55b288 diff --git a/trunk/drivers/char/mem.c b/trunk/drivers/char/mem.c index a074fceb67d3..ad82ec92ebd4 100644 --- a/trunk/drivers/char/mem.c +++ b/trunk/drivers/char/mem.c @@ -26,7 +26,6 @@ #include #include #include -#include #include #include @@ -892,29 +891,23 @@ static int memory_open(struct inode *inode, struct file *filp) { int minor; const struct memdev *dev; - int ret = -ENXIO; - - lock_kernel(); minor = iminor(inode); if (minor >= ARRAY_SIZE(devlist)) - goto out; + return -ENXIO; dev = &devlist[minor]; if (!dev->fops) - goto out; + return -ENXIO; filp->f_op = dev->fops; if (dev->dev_info) filp->f_mapping->backing_dev_info = dev->dev_info; if (dev->fops->open) - ret = dev->fops->open(inode, filp); - else - ret = 0; -out: - unlock_kernel(); - return ret; + return dev->fops->open(inode, filp); + + return 0; } static const struct file_operations memory_fops = {