From b18bcae5d20119d352c39e7461df8cfb364c48b1 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Mon, 22 Feb 2010 15:17:24 -0800 Subject: [PATCH] --- yaml --- r: 199553 b: refs/heads/master c: dbbe33e99f41a6f07e61dbce455964112d8ac72b h: refs/heads/master i: 199551: b1317a4a6941c93a68a5ea2a722d94793bd60af9 v: v3 --- [refs] | 2 +- trunk/scripts/headers_check.pl | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/[refs] b/[refs] index 44df4719ff0d..2c786994aad2 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 91416cfdf98bdbc828fd3e5ca7208beba5979d63 +refs/heads/master: dbbe33e99f41a6f07e61dbce455964112d8ac72b diff --git a/trunk/scripts/headers_check.pl b/trunk/scripts/headers_check.pl index db1dd7a549f2..50d6cfd1fa77 100644 --- a/trunk/scripts/headers_check.pl +++ b/trunk/scripts/headers_check.pl @@ -28,11 +28,12 @@ my $filename; foreach my $file (@files) { - local *FH; $filename = $file; - open(FH, "<$filename") or die "$filename: $!\n"; + + open(my $fh, '<', $filename) + or die "$filename: $!\n"; $lineno = 0; - while ($line = ) { + while ($line = <$fh>) { $lineno++; &check_include(); &check_asm_types(); @@ -40,7 +41,7 @@ &check_declarations(); # Dropped for now. Too much noise &check_config(); } - close FH; + close $fh; } exit $ret; @@ -78,7 +79,7 @@ sub check_config } my $linux_asm_types; -sub check_asm_types() +sub check_asm_types { if ($filename =~ /types.h|int-l64.h|int-ll64.h/o) { return;