From b1db38305ac6c5cc59a561b00fe9576f6de82a32 Mon Sep 17 00:00:00 2001 From: Josef Bacik Date: Sun, 23 May 2010 11:00:55 -0400 Subject: [PATCH] --- yaml --- r: 199004 b: refs/heads/master c: c2c6ca417e2db7a519e6e92c82f4a933d940d076 h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/fs/direct-io.c | 20 ++++++++++++++++++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/[refs] b/[refs] index 0be2e9af7302..9de208e39730 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: facd07b07d2a7988f5ce849558838cc953847637 +refs/heads/master: c2c6ca417e2db7a519e6e92c82f4a933d940d076 diff --git a/trunk/fs/direct-io.c b/trunk/fs/direct-io.c index 5949947b060a..da111aacb46e 100644 --- a/trunk/fs/direct-io.c +++ b/trunk/fs/direct-io.c @@ -632,10 +632,26 @@ static int dio_send_cur_page(struct dio *dio) int ret = 0; if (dio->bio) { + loff_t cur_offset = dio->block_in_file << dio->blkbits; + loff_t bio_next_offset = dio->logical_offset_in_bio + + dio->bio->bi_size; + /* - * See whether this new request is contiguous with the old + * See whether this new request is contiguous with the old. + * + * Btrfs cannot handl having logically non-contiguous requests + * submitted. For exmple if you have + * + * Logical: [0-4095][HOLE][8192-12287] + * Phyiscal: [0-4095] [4096-8181] + * + * We cannot submit those pages together as one BIO. So if our + * current logical offset in the file does not equal what would + * be the next logical offset in the bio, submit the bio we + * have. */ - if (dio->final_block_in_bio != dio->cur_page_block) + if (dio->final_block_in_bio != dio->cur_page_block || + cur_offset != bio_next_offset) dio_bio_submit(dio); /* * Submit now if the underlying fs is about to perform a