From b2c8eaf02e3c25bb2639f19d7d3f5fbe64e4f906 Mon Sep 17 00:00:00 2001 From: Ravishankar Date: Thu, 7 Jul 2011 17:35:27 +0530 Subject: [PATCH] --- yaml --- r: 260015 b: refs/heads/master c: b041267ea819054aa9b406efc94fe8821ea2e67b h: refs/heads/master i: 260013: a2b183ddd5f220b0521e538bc19abf2d9e156bf4 260011: c25336690811fd5209404b5ac4e58c5e44aa06f9 260007: a6685334347d096e1cd40410bf5bed58731125d3 259999: d2d985dbad5f34bc77e109c0428475f269c5bdea v: v3 --- [refs] | 2 +- trunk/drivers/staging/comedi/drivers/serial2002.c | 15 ++++++--------- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/[refs] b/[refs] index d0617c832d26..39786af78d32 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: cbecb8bf564f706e7b4346d54be8a39f0309b91c +refs/heads/master: b041267ea819054aa9b406efc94fe8821ea2e67b diff --git a/trunk/drivers/staging/comedi/drivers/serial2002.c b/trunk/drivers/staging/comedi/drivers/serial2002.c index ebfce33f0b4f..8041d8fb801d 100644 --- a/trunk/drivers/staging/comedi/drivers/serial2002.c +++ b/trunk/drivers/staging/comedi/drivers/serial2002.c @@ -38,7 +38,7 @@ Status: in development #include #include -#include +#include #include #include #include @@ -192,9 +192,8 @@ static int tty_read(struct file *f, int timeout) elapsed = (1000000 * (now.tv_sec - start.tv_sec) + now.tv_usec - start.tv_usec); - if (elapsed > timeout) { + if (elapsed > timeout) break; - } set_current_state(TASK_INTERRUPTIBLE); schedule_timeout(((timeout - elapsed) * HZ) / 10000); @@ -204,9 +203,8 @@ static int tty_read(struct file *f, int timeout) unsigned char ch; f->f_pos = 0; - if (f->f_op->read(f, &ch, 1, &f->f_pos) == 1) { + if (f->f_op->read(f, &ch, 1, &f->f_pos) == 1) result = ch; - } } } else { /* Device does not support poll, busy wait */ @@ -215,9 +213,8 @@ static int tty_read(struct file *f, int timeout) unsigned char ch; retries++; - if (retries >= timeout) { + if (retries >= timeout) break; - } f->f_pos = 0; if (f->f_op->read(f, &ch, 1, &f->f_pos) == 1) { @@ -329,7 +326,7 @@ static struct serial_data serial_read(struct file *f, int timeout) length++; if (data < 0) { - printk("serial2002 error\n"); + printk(KERN_ERR "serial2002 error\n"); break; } else if (data & 0x80) { result.value = (result.value << 7) | (data & 0x7f); @@ -402,7 +399,7 @@ static int serial_2002_open(struct comedi_device *dev) devpriv->tty = filp_open(port, O_RDWR, 0); if (IS_ERR(devpriv->tty)) { result = (int)PTR_ERR(devpriv->tty); - printk("serial_2002: file open error = %d\n", result); + printk(KERN_ERR "serial_2002: file open error = %d\n", result); } else { struct config_t {