diff --git a/[refs] b/[refs] index 3ab837e18bb7..59cd094947ab 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 5f47c7eac65a45e33d7fe390effe75ec5c74f8bf +refs/heads/master: f644d47af3834b603d909c212287d0c21ec3ebbb diff --git a/trunk/drivers/ide/pci/scc_pata.c b/trunk/drivers/ide/pci/scc_pata.c index 7b87488e3daa..a96333c74bf1 100644 --- a/trunk/drivers/ide/pci/scc_pata.c +++ b/trunk/drivers/ide/pci/scc_pata.c @@ -165,9 +165,9 @@ scc_ide_outbsync(ide_drive_t * drive, u8 addr, unsigned long port) ide_hwif_t *hwif = HWIF(drive); out_be32((void*)port, addr); - __asm__ __volatile__("eieio":::"memory"); + eieio(); in_be32((void*)(hwif->dma_base + 0x01c)); - __asm__ __volatile__("eieio":::"memory"); + eieio(); } static void diff --git a/trunk/fs/coda/dir.c b/trunk/fs/coda/dir.c index 8e61236abf4a..04a3dd84c993 100644 --- a/trunk/fs/coda/dir.c +++ b/trunk/fs/coda/dir.c @@ -510,20 +510,20 @@ static int coda_venus_readdir(struct file *coda_file, void *buf, vdir = kmalloc(sizeof(*vdir), GFP_KERNEL); if (!vdir) return -ENOMEM; - if (coda_file->f_pos == 0) { + switch (coda_file->f_pos) { + case 0: ret = filldir(buf, ".", 1, 0, de->d_inode->i_ino, DT_DIR); - if (ret < 0) - goto out; + if (ret < 0) break; result++; coda_file->f_pos++; - } - if (coda_file->f_pos == 1) { + /* fallthrough */ + case 1: ret = filldir(buf, "..", 2, 1, de->d_parent->d_inode->i_ino, DT_DIR); - if (ret < 0) - goto out; + if (ret < 0) break; result++; coda_file->f_pos++; - } + /* fallthrough */ + default: while (1) { /* read entries from the directory file */ ret = kernel_read(host_file, coda_file->f_pos - 2, (char *)vdir, @@ -578,7 +578,7 @@ static int coda_venus_readdir(struct file *coda_file, void *buf, * we've already established it is non-zero. */ coda_file->f_pos += vdir->d_reclen; } -out: + } kfree(vdir); return result ? result : ret; } diff --git a/trunk/fs/coda/upcall.c b/trunk/fs/coda/upcall.c index cd561d2e90b0..e4e766e5557c 100644 --- a/trunk/fs/coda/upcall.c +++ b/trunk/fs/coda/upcall.c @@ -632,7 +632,7 @@ int venus_statfs(struct dentry *dentry, struct kstatfs *sfs) /* * coda_upcall and coda_downcall routines. */ -static void coda_block_signals(sigset_t *old) +static void block_signals(sigset_t *old) { spin_lock_irq(¤t->sighand->siglock); *old = current->blocked; @@ -646,7 +646,7 @@ static void coda_block_signals(sigset_t *old) spin_unlock_irq(¤t->sighand->siglock); } -static void coda_unblock_signals(sigset_t *old) +static void unblock_signals(sigset_t *old) { spin_lock_irq(¤t->sighand->siglock); current->blocked = *old; @@ -672,7 +672,7 @@ static inline void coda_waitfor_upcall(struct upc_req *req) sigset_t old; int blocked; - coda_block_signals(&old); + block_signals(&old); blocked = 1; add_wait_queue(&req->uc_sleep, &wait); @@ -689,7 +689,7 @@ static inline void coda_waitfor_upcall(struct upc_req *req) if (blocked && time_after(jiffies, timeout) && CODA_INTERRUPTIBLE(req)) { - coda_unblock_signals(&old); + unblock_signals(&old); blocked = 0; } @@ -704,7 +704,7 @@ static inline void coda_waitfor_upcall(struct upc_req *req) schedule(); } if (blocked) - coda_unblock_signals(&old); + unblock_signals(&old); remove_wait_queue(&req->uc_sleep, &wait); set_current_state(TASK_RUNNING); diff --git a/trunk/net/ipv4/tcp_htcp.c b/trunk/net/ipv4/tcp_htcp.c index 08a02e6045c9..632c05a75883 100644 --- a/trunk/net/ipv4/tcp_htcp.c +++ b/trunk/net/ipv4/tcp_htcp.c @@ -225,7 +225,7 @@ static u32 htcp_recalc_ssthresh(struct sock *sk) return max((tp->snd_cwnd * ca->beta) >> 7, 2U); } -static void htcp_cong_avoid(struct sock *sk, u32 ack, +static void htcp_cong_avoid(struct sock *sk, u32 ack, s32 rtt, u32 in_flight, int data_acked) { struct tcp_sock *tp = tcp_sk(sk);