From b96be3e44b2f39d7b73842bb132f517150c4bda3 Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Sun, 3 Feb 2008 07:58:57 +1100 Subject: [PATCH] --- yaml --- r: 82614 b: refs/heads/master c: 9135f1901ee6449dfe338adf6e40e9c2025b8150 h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/drivers/ieee1394/sbp2.c | 5 ++--- trunk/mm/filemap.c | 8 ++++++-- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/[refs] b/[refs] index b116fd404a17..f4c323c04bc8 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: d59823fa44f7d9babf586b3c705db314aa0f9822 +refs/heads/master: 9135f1901ee6449dfe338adf6e40e9c2025b8150 diff --git a/trunk/drivers/ieee1394/sbp2.c b/trunk/drivers/ieee1394/sbp2.c index 2b889d91e673..28e155a9e2a5 100644 --- a/trunk/drivers/ieee1394/sbp2.c +++ b/trunk/drivers/ieee1394/sbp2.c @@ -1465,10 +1465,9 @@ static void sbp2_prep_command_orb_sg(struct sbp2_command_orb *orb, orb->misc |= ORB_SET_DIRECTION(orb_direction); /* special case if only one element (and less than 64KB in size) */ - if ((scsi_use_sg == 1) && - (sg_dma_len(sg) <= SBP2_MAX_SG_ELEMENT_LENGTH)) { + if (scsi_use_sg == 1 && sg->length <= SBP2_MAX_SG_ELEMENT_LENGTH) { - cmd->dma_size = sg_dma_len(sg); + cmd->dma_size = sg->length; cmd->dma_type = CMD_DMA_PAGE; cmd->cmd_dma = dma_map_page(hi->host->device.parent, sg_page(sg), sg->offset, diff --git a/trunk/mm/filemap.c b/trunk/mm/filemap.c index 89ce6fe5f8be..76bea88cbebc 100644 --- a/trunk/mm/filemap.c +++ b/trunk/mm/filemap.c @@ -1750,7 +1750,11 @@ static void __iov_iter_advance_iov(struct iov_iter *i, size_t bytes) const struct iovec *iov = i->iov; size_t base = i->iov_offset; - while (bytes) { + /* + * The !iov->iov_len check ensures we skip over unlikely + * zero-length segments. + */ + while (bytes || !iov->iov_len) { int copy = min(bytes, iov->iov_len - base); bytes -= copy; @@ -2268,6 +2272,7 @@ static ssize_t generic_perform_write(struct file *file, cond_resched(); + iov_iter_advance(i, copied); if (unlikely(copied == 0)) { /* * If we were unable to copy any data at all, we must @@ -2281,7 +2286,6 @@ static ssize_t generic_perform_write(struct file *file, iov_iter_single_seg_count(i)); goto again; } - iov_iter_advance(i, copied); pos += copied; written += copied;