From ba4ba634712e1d2b4840a5b7babfa27389fb11be Mon Sep 17 00:00:00 2001 From: Peter Hurley Date: Thu, 13 Jun 2013 15:56:37 -0400 Subject: [PATCH] --- yaml --- r: 377307 b: refs/heads/master c: 7c61c3d8f44d5d822f758754287af644307b4af9 h: refs/heads/master i: 377305: 8e17dc10e11a16413d23baa698158f3936de48cb 377303: 64333451b2e65365c1a92db450ccd31da117e7db v: v3 --- [refs] | 2 +- trunk/drivers/tty/pty.c | 13 +++++-------- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/[refs] b/[refs] index 7abbba5d97b9..755f0e8fb3da 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: ef223fb3d1d61c2a95a89cdc02f8e86dac96ddc3 +refs/heads/master: 7c61c3d8f44d5d822f758754287af644307b4af9 diff --git a/trunk/drivers/tty/pty.c b/trunk/drivers/tty/pty.c index 59bfaecc4e14..abfd99089781 100644 --- a/trunk/drivers/tty/pty.c +++ b/trunk/drivers/tty/pty.c @@ -244,14 +244,9 @@ static void pty_flush_buffer(struct tty_struct *tty) static int pty_open(struct tty_struct *tty, struct file *filp) { - int retval = -ENODEV; - if (!tty || !tty->link) - goto out; - - set_bit(TTY_IO_ERROR, &tty->flags); + return -ENODEV; - retval = -EIO; if (test_bit(TTY_OTHER_CLOSED, &tty->flags)) goto out; if (test_bit(TTY_PTY_LOCK, &tty->link->flags)) @@ -262,9 +257,11 @@ static int pty_open(struct tty_struct *tty, struct file *filp) clear_bit(TTY_IO_ERROR, &tty->flags); clear_bit(TTY_OTHER_CLOSED, &tty->link->flags); set_bit(TTY_THROTTLED, &tty->flags); - retval = 0; + return 0; + out: - return retval; + set_bit(TTY_IO_ERROR, &tty->flags); + return -EIO; } static void pty_set_termios(struct tty_struct *tty,