From c01f3dd1a75646798716fa292f3cb2ca8dfb07a0 Mon Sep 17 00:00:00 2001 From: Milan Broz Date: Fri, 8 Dec 2006 02:41:11 -0800 Subject: [PATCH] --- yaml --- r: 43843 b: refs/heads/master c: 31c93a0c29bf96efd806ccf4ee81cacf04f255de h: refs/heads/master i: 43841: de4ae3a46fd1834c2f918ddb04141bf67502bc6f 43839: 42b5abd41203beb2a36e7607770b45c41b680d0c v: v3 --- [refs] | 2 +- trunk/drivers/md/dm-snap.c | 19 ++++++++++++------- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/[refs] b/[refs] index faf28fd2ecb9..d6aee26a2b8b 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 45e157206c732613d1c07e8ceeb1a3e497fb2abf +refs/heads/master: 31c93a0c29bf96efd806ccf4ee81cacf04f255de diff --git a/trunk/drivers/md/dm-snap.c b/trunk/drivers/md/dm-snap.c index bbf861e4fed1..50e084df554e 100644 --- a/trunk/drivers/md/dm-snap.c +++ b/trunk/drivers/md/dm-snap.c @@ -564,6 +564,17 @@ static int snapshot_ctr(struct dm_target *ti, unsigned int argc, char **argv) return r; } +static void __free_exceptions(struct dm_snapshot *s) +{ + kcopyd_client_destroy(s->kcopyd_client); + s->kcopyd_client = NULL; + + exit_exception_table(&s->pending, pending_cache); + exit_exception_table(&s->complete, exception_cache); + + s->store.destroy(&s->store); +} + static void snapshot_dtr(struct dm_target *ti) { struct dm_snapshot *s = (struct dm_snapshot *) ti->private; @@ -574,13 +585,7 @@ static void snapshot_dtr(struct dm_target *ti) /* After this returns there can be no new kcopyd jobs. */ unregister_snapshot(s); - kcopyd_client_destroy(s->kcopyd_client); - - exit_exception_table(&s->pending, pending_cache); - exit_exception_table(&s->complete, exception_cache); - - /* Deallocate memory used */ - s->store.destroy(&s->store); + __free_exceptions(s); dm_put_device(ti, s->origin); dm_put_device(ti, s->cow);