From c42a1d6cf008d6dbb210ed868078482c276ae073 Mon Sep 17 00:00:00 2001 From: Hannes Eder Date: Wed, 25 Feb 2009 10:32:39 +0000 Subject: [PATCH] --- yaml --- r: 134775 b: refs/heads/master c: e57c624be8f99e56560fd2f4f485fe29f28dd74f h: refs/heads/master i: 134773: 2d5a04c99ff95c7d1651f0bfb2f9948955c1b14b 134771: a205f0ccae892ecbb089c50b5c1e3f47659c4098 134767: 10db6b6282061328805ab57fb0ef838e6d07e81d v: v3 --- [refs] | 2 +- trunk/net/decnet/af_decnet.c | 17 +++++++++-------- trunk/net/decnet/dn_dev.c | 1 - trunk/net/decnet/sysctl_net_decnet.c | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/[refs] b/[refs] index 04194d95360d..0530eaa9c6b8 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 8521c27ee79533db444dcac291992b6bf8d61fc8 +refs/heads/master: e57c624be8f99e56560fd2f4f485fe29f28dd74f diff --git a/trunk/net/decnet/af_decnet.c b/trunk/net/decnet/af_decnet.c index 963da86d4ecf..ec233b64f853 100644 --- a/trunk/net/decnet/af_decnet.c +++ b/trunk/net/decnet/af_decnet.c @@ -1246,11 +1246,12 @@ static int dn_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) case TIOCINQ: lock_sock(sk); - if ((skb = skb_peek(&scp->other_receive_queue)) != NULL) { + skb = skb_peek(&scp->other_receive_queue); + if (skb) { amount = skb->len; } else { - struct sk_buff *skb = sk->sk_receive_queue.next; - for(;;) { + skb = sk->sk_receive_queue.next; + for (;;) { if (skb == (struct sk_buff *)&sk->sk_receive_queue) break; @@ -1579,16 +1580,16 @@ static int __dn_getsockopt(struct socket *sock, int level,int optname, char __us default: #ifdef CONFIG_NETFILTER { - int val, len; + int ret, len; if(get_user(len, optlen)) return -EFAULT; - val = nf_getsockopt(sk, PF_DECnet, optname, + ret = nf_getsockopt(sk, PF_DECnet, optname, optval, &len); - if (val >= 0) - val = put_user(len, optlen); - return val; + if (ret >= 0) + ret = put_user(len, optlen); + return ret; } #endif case DSO_STREAM: diff --git a/trunk/net/decnet/dn_dev.c b/trunk/net/decnet/dn_dev.c index b6c80f3b8185..1c6a5bb6f0c8 100644 --- a/trunk/net/decnet/dn_dev.c +++ b/trunk/net/decnet/dn_dev.c @@ -684,7 +684,6 @@ static int dn_nl_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg) return -ENODEV; if ((dn_db = dev->dn_ptr) == NULL) { - int err; dn_db = dn_dev_create(dev, &err); if (!dn_db) return err; diff --git a/trunk/net/decnet/sysctl_net_decnet.c b/trunk/net/decnet/sysctl_net_decnet.c index 965397af9a80..5bcd592ae6dd 100644 --- a/trunk/net/decnet/sysctl_net_decnet.c +++ b/trunk/net/decnet/sysctl_net_decnet.c @@ -179,7 +179,7 @@ static int dn_node_address_handler(ctl_table *table, int write, } if (write) { - int len = (*lenp < DN_ASCBUF_LEN) ? *lenp : (DN_ASCBUF_LEN-1); + len = (*lenp < DN_ASCBUF_LEN) ? *lenp : (DN_ASCBUF_LEN-1); if (copy_from_user(addr, buffer, len)) return -EFAULT;