From c710af088d4c9d738d621990d78a9ed04ba9c04c Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Tue, 8 Aug 2006 14:08:59 +0900 Subject: [PATCH] --- yaml --- r: 33293 b: refs/heads/master c: 22aac0896b1b0b8cabaf00714c55dd12f25d5738 h: refs/heads/master i: 33291: ecb43014c161225965cd8dcbd628e816f8811f00 v: v3 --- [refs] | 2 +- trunk/drivers/scsi/libata-scsi.c | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/[refs] b/[refs] index 5902e81e23dc..4b92e7be2905 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 85455dd34219376dcc7dce94bea67058f0b7d731 +refs/heads/master: 22aac0896b1b0b8cabaf00714c55dd12f25d5738 diff --git a/trunk/drivers/scsi/libata-scsi.c b/trunk/drivers/scsi/libata-scsi.c index 7ced41ecde86..e92c31d698ff 100644 --- a/trunk/drivers/scsi/libata-scsi.c +++ b/trunk/drivers/scsi/libata-scsi.c @@ -2353,6 +2353,19 @@ static void atapi_qc_complete(struct ata_queued_cmd *qc) ata_gen_ata_desc_sense(qc); } + /* SCSI EH automatically locks door if sdev->locked is + * set. Sometimes door lock request continues to + * fail, for example, when no media is present. This + * creates a loop - SCSI EH issues door lock which + * fails and gets invoked again to acquire sense data + * for the failed command. + * + * If door lock fails, always clear sdev->locked to + * avoid this infinite loop. + */ + if (qc->cdb[0] == ALLOW_MEDIUM_REMOVAL) + qc->dev->sdev->locked = 0; + qc->scsicmd->result = SAM_STAT_CHECK_CONDITION; qc->scsidone(cmd); ata_qc_free(qc);