From c815a4aa30d215e86a0bc13ecc78f4f9612d4dc2 Mon Sep 17 00:00:00 2001 From: Jonathan Corbet Date: Fri, 16 May 2008 13:57:31 -0600 Subject: [PATCH] --- yaml --- r: 100307 b: refs/heads/master c: 65f37b790bd7ba15413838579470296a709c45e6 h: refs/heads/master i: 100305: f24dfbcaff341875735461e7e63d4f7b64409f8b 100303: 86a848d50f2528da86a821672f027e7390e61ca5 v: v3 --- [refs] | 2 +- trunk/drivers/char/dsp56k.c | 16 +++++++++++----- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/[refs] b/[refs] index cab678fcc9b6..b779374e7ca3 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: c0bed680f0ca603864375ed5f9fed4296a53aa62 +refs/heads/master: 65f37b790bd7ba15413838579470296a709c45e6 diff --git a/trunk/drivers/char/dsp56k.c b/trunk/drivers/char/dsp56k.c index a69c65283260..7bf7485377e6 100644 --- a/trunk/drivers/char/dsp56k.c +++ b/trunk/drivers/char/dsp56k.c @@ -33,6 +33,7 @@ #include #include #include +#include #include #include @@ -436,13 +437,17 @@ static unsigned int dsp56k_poll(struct file *file, poll_table *wait) static int dsp56k_open(struct inode *inode, struct file *file) { int dev = iminor(inode) & 0x0f; + int ret = 0; + lock_kernel(); switch(dev) { case DSP56K_DEV_56001: - if (test_and_set_bit(0, &dsp56k.in_use)) - return -EBUSY; + if (test_and_set_bit(0, &dsp56k.in_use)) { + ret = -EBUSY; + goto out; + } dsp56k.timeout = TIMEOUT; dsp56k.maxio = MAXIO; @@ -458,10 +463,11 @@ static int dsp56k_open(struct inode *inode, struct file *file) break; default: - return -ENODEV; + ret = -ENODEV; } - - return 0; +out: + unlock_kernel(); + return ret; } static int dsp56k_release(struct inode *inode, struct file *file)