From c9e8df087eddf187831d7edf188eb32990edf5b4 Mon Sep 17 00:00:00 2001
From: Andy Adamson <andros@netapp.com>
Date: Thu, 14 Jan 2010 17:45:05 -0500
Subject: [PATCH] --- yaml --- r: 186137 b: refs/heads/master c:
 b92b30190093377828efcde5fc4cf7598fa1ee46 h: refs/heads/master i:   186135:
 6e6acb481e9a10ff1bd2a4e984bd21a47e2c1dc4 v: v3

---
 [refs]                      | 2 +-
 trunk/fs/nfs/callback_xdr.c | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/[refs] b/[refs]
index c0704de342f7..e4856c3313b2 100644
--- a/[refs]
+++ b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 31d2b4356b054537c35f4f8a7533e0b4a494dcc6
+refs/heads/master: b92b30190093377828efcde5fc4cf7598fa1ee46
diff --git a/trunk/fs/nfs/callback_xdr.c b/trunk/fs/nfs/callback_xdr.c
index 6ae327871b86..d3e07f469949 100644
--- a/trunk/fs/nfs/callback_xdr.c
+++ b/trunk/fs/nfs/callback_xdr.c
@@ -625,16 +625,19 @@ static __be32 process_op(uint32_t minorversion, int nop,
 				preprocess_nfs4_op(op_nr, &op);
 	if (status == htonl(NFS4ERR_OP_ILLEGAL))
 		op_nr = OP_CB_ILLEGAL;
+	if (status)
+		goto encode_hdr;
 
 	maxlen = xdr_out->end - xdr_out->p;
 	if (maxlen > 0 && maxlen < PAGE_SIZE) {
-		if (likely(status == 0 && op->decode_args != NULL))
+		if (likely(op->decode_args != NULL))
 			status = op->decode_args(rqstp, xdr_in, argp);
 		if (likely(status == 0 && op->process_op != NULL))
 			status = op->process_op(argp, resp);
 	} else
 		status = htonl(NFS4ERR_RESOURCE);
 
+encode_hdr:
 	res = encode_op_hdr(xdr_out, op_nr, status);
 	if (unlikely(res))
 		return res;