From cbe046c52427c4310424d3000de721eb6b584145 Mon Sep 17 00:00:00 2001
From: Hans Verkuil <hverkuil@xs4all.nl>
Date: Sat, 23 Aug 2008 06:27:59 -0300
Subject: [PATCH] --- yaml --- r: 113865 b: refs/heads/master c:
 d6e7497eaf9889d39a070f60309a9bcea1fd29f6 h: refs/heads/master i:   113863:
 948e804fa7ae22f43a85044e0aba5270789dac36 v: v3

---
 [refs]                               |  2 +-
 trunk/drivers/media/video/v4l2-dev.c | 16 ++--------------
 2 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/[refs] b/[refs]
index 292f965f9a69..477db4c424e7 100644
--- a/[refs]
+++ b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: aa5e90af7d78d1711f8f4275ce3638817c0023dc
+refs/heads/master: d6e7497eaf9889d39a070f60309a9bcea1fd29f6
diff --git a/trunk/drivers/media/video/v4l2-dev.c b/trunk/drivers/media/video/v4l2-dev.c
index fda48a2efda6..ff219df4b725 100644
--- a/trunk/drivers/media/video/v4l2-dev.c
+++ b/trunk/drivers/media/video/v4l2-dev.c
@@ -84,11 +84,6 @@ static void video_release(struct device *cd)
 {
 	struct video_device *vfd = container_of(cd, struct video_device, dev);
 
-#if 1
-	/* needed until all drivers are fixed */
-	if (!vfd->release)
-		return;
-#endif
 	vfd->release(vfd);
 }
 
@@ -233,8 +228,8 @@ int video_register_device_index(struct video_device *vfd, int type, int nr,
 	int ret;
 	char *name_base;
 
-	if (vfd == NULL)
-		return -EINVAL;
+	/* the release callback MUST be present */
+	BUG_ON(!vfd->release);
 
 	if (vfd == NULL)
 		return -EINVAL;
@@ -312,13 +307,6 @@ int video_register_device_index(struct video_device *vfd, int type, int nr,
 		goto fail_minor;
 	}
 
-#if 1
-	/* needed until all drivers are fixed */
-	if (!vfd->release)
-		printk(KERN_WARNING "videodev: \"%s\" has no release callback. "
-		       "Please fix your driver for proper sysfs support, see "
-		       "http://lwn.net/Articles/36850/\n", vfd->name);
-#endif
 	return 0;
 
 fail_minor: