From d1c45047d3043b5fd8231d77272c430046c670d9 Mon Sep 17 00:00:00 2001 From: Steve French Date: Fri, 27 Jan 2006 15:11:47 -0800 Subject: [PATCH] --- yaml --- r: 19483 b: refs/heads/master c: eb9bdaa3f3b9d30d09bcad47037216aa39639b8e h: refs/heads/master i: 19481: 4ecde32460ce4cf3ca3f7ae274b2dca4dabbb512 19479: 16266d618c13495af55e82cf426358c826115e4b v: v3 --- [refs] | 2 +- trunk/fs/cifs/file.c | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/[refs] b/[refs] index 2ecc4992e071..676bb1c3490e 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 17cbbafe8e82bde4258e407ce043b61f4f9a350f +refs/heads/master: eb9bdaa3f3b9d30d09bcad47037216aa39639b8e diff --git a/trunk/fs/cifs/file.c b/trunk/fs/cifs/file.c index 77c990f0cb98..d17c97d07c80 100644 --- a/trunk/fs/cifs/file.c +++ b/trunk/fs/cifs/file.c @@ -1190,7 +1190,6 @@ static int cifs_writepages(struct address_space *mapping, /* BB what if continued retry is requested via mount flags? */ set_bit(AS_EIO, &mapping->flags); - SetPageError(page); } else { cifs_stats_bytes_written(cifs_sb->tcon, bytes_written); @@ -1198,6 +1197,13 @@ static int cifs_writepages(struct address_space *mapping, } for (i = 0; i < n_iov; i++) { page = pvec.pages[first + i]; + /* Should we also set page error on + success rc but too little data written? */ + /* BB investigate retry logic on temporary + server crash cases and how recovery works + when page marked as error */ + if(rc) + SetPageError(page); kunmap(page); unlock_page(page); page_cache_release(page);