From d22a467eec74bfcbccc93f361ddff699f1cba62f Mon Sep 17 00:00:00 2001 From: Oleg Drokin Date: Sat, 25 Mar 2006 03:07:02 -0800 Subject: [PATCH] --- yaml --- r: 23527 b: refs/heads/master c: 9a56c213929d83139fd1e12727e1037d71b519f8 h: refs/heads/master i: 23525: ad4b3e0854cb5ff9759cc607c94ef8d8cdaff302 23523: 0f0fe44c2dec32a2796ea8cf3136524b4bbfb1df 23519: 85c3b4dafad83775b71c089d65c3b058b95ad0fc v: v3 --- [refs] | 2 +- trunk/fs/open.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/[refs] b/[refs] index 7a0af7249c3e..662b34570a88 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: b500531e6f5f234ed267bd7060ee06d144faf0ca +refs/heads/master: 9a56c213929d83139fd1e12727e1037d71b519f8 diff --git a/trunk/fs/open.c b/trunk/fs/open.c index 1091dadd6c38..7d02d19bd0a2 100644 --- a/trunk/fs/open.c +++ b/trunk/fs/open.c @@ -890,6 +890,10 @@ EXPORT_SYMBOL(filp_open); * a fully instantiated struct file to the caller. * This function is meant to be called from within a filesystem's * lookup method. + * Beware of calling it for non-regular files! Those ->open methods might block + * (e.g. in fifo_open), leaving you with parent locked (and in case of fifo, + * leading to a deadlock, as nobody can open that fifo anymore, because + * another process to open fifo will block on locked parent when doing lookup). * Note that in case of error, nd->intent.open.file is destroyed, but the * path information remains valid. * If the open callback is set to NULL, then the standard f_op->open()