From df5b512d214010c96abf3e453bb7264d1d1a8352 Mon Sep 17 00:00:00 2001 From: Oleg Nesterov Date: Fri, 24 Apr 2009 01:02:45 +0200 Subject: [PATCH] --- yaml --- r: 143830 b: refs/heads/master c: 437f7fdb607f32b737e4da9f14bebcfdac2c90c3 h: refs/heads/master v: v3 --- [refs] | 2 +- trunk/fs/exec.c | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/[refs] b/[refs] index 55912739ebe4..ccbc22c232ce 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 8c652f96d3852b97a49c331cd0bb02d22f3cb31b +refs/heads/master: 437f7fdb607f32b737e4da9f14bebcfdac2c90c3 diff --git a/trunk/fs/exec.c b/trunk/fs/exec.c index a2e6989dbc3a..a3a8ce83940f 100644 --- a/trunk/fs/exec.c +++ b/trunk/fs/exec.c @@ -1060,7 +1060,6 @@ EXPORT_SYMBOL(install_exec_creds); int check_unsafe_exec(struct linux_binprm *bprm) { struct task_struct *p = current, *t; - unsigned long flags; unsigned n_fs; int res = 0; @@ -1068,11 +1067,12 @@ int check_unsafe_exec(struct linux_binprm *bprm) n_fs = 1; write_lock(&p->fs->lock); - lock_task_sighand(p, &flags); + rcu_read_lock(); for (t = next_thread(p); t != p; t = next_thread(t)) { if (t->fs == p->fs) n_fs++; } + rcu_read_unlock(); if (p->fs->users > n_fs) { bprm->unsafe |= LSM_UNSAFE_SHARE; @@ -1083,8 +1083,6 @@ int check_unsafe_exec(struct linux_binprm *bprm) res = 1; } } - - unlock_task_sighand(p, &flags); write_unlock(&p->fs->lock); return res;