From e3698c470bf5d55cd6d5094596e578cfcb370ec2 Mon Sep 17 00:00:00 2001
From: Ming Lei <tom.leiming@gmail.com>
Date: Thu, 23 Apr 2009 22:31:52 +0800
Subject: [PATCH] --- yaml --- r: 151235 b: refs/heads/master c:
 6acf70f078ca42a63397b8b84bf6383b01303009 h: refs/heads/master i:   151233:
 eb7c04fa2d4820ab51c4cd03f6c917485a4c8584   151231:
 644530c13e3dac4f675f9bc78799ab4b2d7cad12 v: v3

---
 [refs]                              | 2 +-
 trunk/drivers/base/firmware_class.c | 8 +++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/[refs] b/[refs]
index b8ab6bb8e1ce..70ac6f67b81e 100644
--- a/[refs]
+++ b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 557411eb2ce61ef5e87bd759a6f86881586df857
+refs/heads/master: 6acf70f078ca42a63397b8b84bf6383b01303009
diff --git a/trunk/drivers/base/firmware_class.c b/trunk/drivers/base/firmware_class.c
index 8a267c427629..2d296b7f7034 100644
--- a/trunk/drivers/base/firmware_class.c
+++ b/trunk/drivers/base/firmware_class.c
@@ -356,7 +356,7 @@ static void fw_dev_release(struct device *dev)
 		__free_page(fw_priv->pages[i]);
 	kfree(fw_priv->pages);
 	kfree(fw_priv);
-	kfree(dev);
+	put_device(dev);
 
 	module_put(THIS_MODULE);
 }
@@ -400,14 +400,16 @@ static int fw_register_device(struct device **dev_p, const char *fw_name,
 	retval = device_register(f_dev);
 	if (retval) {
 		dev_err(device, "%s: device_register failed\n", __func__);
-		goto error_kfree;
+		put_device(f_dev);
+		goto error_kfree1;
 	}
 	*dev_p = f_dev;
 	return 0;
 
 error_kfree:
-	kfree(fw_priv);
 	kfree(f_dev);
+error_kfree1:
+	kfree(fw_priv);
 	return retval;
 }