From e9c95ac4a4f38d2722307b51935ad1e2df9441e2 Mon Sep 17 00:00:00 2001 From: Felipe Balbi Date: Wed, 12 Sep 2012 16:28:03 +0530 Subject: [PATCH] --- yaml --- r: 333383 b: refs/heads/master c: 66b9298878742f08cb6e79b7c7d5632d782fd1e1 h: refs/heads/master i: 333381: b5a8a1085493d7869339baa4507ed7aad525e1f5 333379: 7c21d3398b901c48ed9f90b07df8ac892b8bf517 333375: 5b0e89b09ae172b6c40374c98aab4b37e8e974e6 v: v3 --- [refs] | 2 +- trunk/drivers/i2c/busses/i2c-omap.c | 20 ++++++++++++++------ 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/[refs] b/[refs] index 6a2343cfed12..587be81c5248 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 3312d25e1abdc41be8a75a1b2c3ccaa39a14ed99 +refs/heads/master: 66b9298878742f08cb6e79b7c7d5632d782fd1e1 diff --git a/trunk/drivers/i2c/busses/i2c-omap.c b/trunk/drivers/i2c/busses/i2c-omap.c index 2c7d7cc30e95..40451341c479 100644 --- a/trunk/drivers/i2c/busses/i2c-omap.c +++ b/trunk/drivers/i2c/busses/i2c-omap.c @@ -827,20 +827,28 @@ omap_i2c_isr(int this_irq, void *dev_id) struct omap_i2c_dev *dev = dev_id; u16 bits; u16 stat; - int err, count = 0; + int err = 0, count = 0; if (pm_runtime_suspended(dev->dev)) return IRQ_NONE; - bits = omap_i2c_read_reg(dev, OMAP_I2C_IE_REG); - while ((stat = (omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG))) & bits) { + do { + bits = omap_i2c_read_reg(dev, OMAP_I2C_IE_REG); + stat = omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG); + stat &= bits; + + if (!stat) { + /* my work here is done */ + return IRQ_HANDLED; + } + dev_dbg(dev->dev, "IRQ (ISR = 0x%04x)\n", stat); if (count++ == 100) { dev_warn(dev->dev, "Too much work in one IRQ\n"); - break; + omap_i2c_complete_cmd(dev, err); + return IRQ_HANDLED; } - err = 0; complete: /* * Ack the stat in one go, but [R/X]DR and [R/X]RDY should be @@ -940,7 +948,7 @@ omap_i2c_isr(int this_irq, void *dev_id) dev_err(dev->dev, "Transmit underflow\n"); dev->cmd_err |= OMAP_I2C_STAT_XUDF; } - } + } while (stat); return count ? IRQ_HANDLED : IRQ_NONE; }