From ef7bb4a1a32c9f8cb1e1993c3f5f13e01bca8fe9 Mon Sep 17 00:00:00 2001 From: Artem Bityutskiy Date: Wed, 25 Jul 2012 18:12:02 +0300 Subject: [PATCH] --- yaml --- r: 321391 b: refs/heads/master c: d3009c6cffd37e9bc8435a002fe862548c440d97 h: refs/heads/master i: 321389: dbb299038fd4e2465171e8241bf1b39e53882988 321387: d672bd183527a68128eb80920f92af4049fc4554 321383: c8fd6e979d7b7296382d4b1d0851a2c496e074bf 321375: 745c6a7a9cc268f6a0df839037e7092b5c9538c3 v: v3 --- [refs] | 2 +- trunk/fs/ext3/inode.c | 8 -------- trunk/fs/ext3/super.c | 11 ----------- 3 files changed, 1 insertion(+), 20 deletions(-) diff --git a/[refs] b/[refs] index 5825a8f3d199..ec8b7f013a3b 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 6601fac822778aa6003aed37d8ba7acdc9a4f369 +refs/heads/master: d3009c6cffd37e9bc8435a002fe862548c440d97 diff --git a/trunk/fs/ext3/inode.c b/trunk/fs/ext3/inode.c index 9a4a5c48b1c9..a07597307fd1 100644 --- a/trunk/fs/ext3/inode.c +++ b/trunk/fs/ext3/inode.c @@ -3459,14 +3459,6 @@ ext3_reserve_inode_write(handle_t *handle, struct inode *inode, * inode out, but prune_icache isn't a user-visible syncing function. * Whenever the user wants stuff synced (sys_sync, sys_msync, sys_fsync) * we start and wait on commits. - * - * Is this efficient/effective? Well, we're being nice to the system - * by cleaning up our inodes proactively so they can be reaped - * without I/O. But we are potentially leaving up to five seconds' - * worth of inodes floating about which prune_icache wants us to - * write out. One way to fix that would be to get prune_icache() - * to do a write_super() to free up some memory. It has the desired - * effect. */ int ext3_mark_inode_dirty(handle_t *handle, struct inode *inode) { diff --git a/trunk/fs/ext3/super.c b/trunk/fs/ext3/super.c index ff9bcdc5b0d5..8c892e93d8e7 100644 --- a/trunk/fs/ext3/super.c +++ b/trunk/fs/ext3/super.c @@ -64,11 +64,6 @@ static int ext3_freeze(struct super_block *sb); /* * Wrappers for journal_start/end. - * - * The only special thing we need to do here is to make sure that all - * journal_end calls result in the superblock being marked dirty, so - * that sync() will call the filesystem's write_super callback if - * appropriate. */ handle_t *ext3_journal_start_sb(struct super_block *sb, int nblocks) { @@ -90,12 +85,6 @@ handle_t *ext3_journal_start_sb(struct super_block *sb, int nblocks) return journal_start(journal, nblocks); } -/* - * The only special thing we need to do here is to make sure that all - * journal_stop calls result in the superblock being marked dirty, so - * that sync() will call the filesystem's write_super callback if - * appropriate. - */ int __ext3_journal_stop(const char *where, handle_t *handle) { struct super_block *sb;