diff --git a/[refs] b/[refs] index 5ee5628a2fcf..fbab2b85d998 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: d5bb68adda7cc179e8efadeaa3a283cb470f13a6 +refs/heads/master: 3a6a6c16be78472a52f6dd7d88913373b42ad0f7 diff --git a/trunk/fs/btrfs/inode.c b/trunk/fs/btrfs/inode.c index dbe1aabf96cd..78ad38ddd01f 100644 --- a/trunk/fs/btrfs/inode.c +++ b/trunk/fs/btrfs/inode.c @@ -2122,8 +2122,10 @@ static void btrfs_read_locked_inode(struct inode *inode) * any xattrs or acls */ maybe_acls = acls_after_inode_item(leaf, path->slots[0], inode->i_ino); - if (!maybe_acls) - cache_no_acl(inode); + if (!maybe_acls) { + inode->i_acl = NULL; + inode->i_default_acl = NULL; + } BTRFS_I(inode)->block_group = btrfs_find_block_group(root, 0, alloc_group_block, 0); diff --git a/trunk/fs/jffs2/acl.c b/trunk/fs/jffs2/acl.c index 8fcb6239218e..edd2ad6416d8 100644 --- a/trunk/fs/jffs2/acl.c +++ b/trunk/fs/jffs2/acl.c @@ -284,7 +284,8 @@ int jffs2_init_acl_pre(struct inode *dir_i, struct inode *inode, int *i_mode) struct posix_acl *acl, *clone; int rc; - cache_no_acl(inode); + inode->i_default_acl = NULL; + inode->i_acl = NULL; if (S_ISLNK(*i_mode)) return 0; /* Symlink always has no-ACL */ diff --git a/trunk/fs/jfs/acl.c b/trunk/fs/jfs/acl.c index 91fa3ad6e8c2..f272bf032e1e 100644 --- a/trunk/fs/jfs/acl.c +++ b/trunk/fs/jfs/acl.c @@ -118,16 +118,15 @@ static int jfs_set_acl(tid_t tid, struct inode *inode, int type, static int jfs_check_acl(struct inode *inode, int mask) { - struct posix_acl *acl = jfs_get_acl(inode, ACL_TYPE_ACCESS); - - if (IS_ERR(acl)) - return PTR_ERR(acl); - if (acl) { - int error = posix_acl_permission(inode, acl, mask); + if (inode->i_acl == ACL_NOT_CACHED) { + struct posix_acl *acl = jfs_get_acl(inode, ACL_TYPE_ACCESS); + if (IS_ERR(acl)) + return PTR_ERR(acl); posix_acl_release(acl); - return error; } + if (inode->i_acl) + return posix_acl_permission(inode, inode->i_acl, mask); return -EAGAIN; } diff --git a/trunk/include/linux/posix_acl.h b/trunk/include/linux/posix_acl.h index 065a3652a3ea..0cdba01b7756 100644 --- a/trunk/include/linux/posix_acl.h +++ b/trunk/include/linux/posix_acl.h @@ -83,7 +83,6 @@ extern int posix_acl_chmod_masq(struct posix_acl *, mode_t); extern struct posix_acl *get_posix_acl(struct inode *, int); extern int set_posix_acl(struct inode *, int, struct posix_acl *); -#ifdef CONFIG_FS_POSIX_ACL static inline struct posix_acl *get_cached_acl(struct inode *inode, int type) { struct posix_acl **p, *acl; @@ -147,14 +146,5 @@ static inline void forget_cached_acl(struct inode *inode, int type) if (old != ACL_NOT_CACHED) posix_acl_release(old); } -#endif - -static inline void cache_no_acl(struct inode *inode) -{ -#ifdef CONFIG_FS_POSIX_ACL - inode->i_acl = NULL; - inode->i_default_acl = NULL; -#endif -} #endif /* __LINUX_POSIX_ACL_H */ diff --git a/trunk/kernel/Makefile b/trunk/kernel/Makefile index da750010a6fc..780c8dcf4516 100644 --- a/trunk/kernel/Makefile +++ b/trunk/kernel/Makefile @@ -69,8 +69,8 @@ obj-$(CONFIG_IKCONFIG) += configs.o obj-$(CONFIG_RESOURCE_COUNTERS) += res_counter.o obj-$(CONFIG_STOP_MACHINE) += stop_machine.o obj-$(CONFIG_KPROBES_SANITY_TEST) += test_kprobes.o -obj-$(CONFIG_AUDIT) += audit.o auditfilter.o -obj-$(CONFIG_AUDITSYSCALL) += auditsc.o audit_watch.o +obj-$(CONFIG_AUDIT) += audit.o auditfilter.o audit_watch.o +obj-$(CONFIG_AUDITSYSCALL) += auditsc.o obj-$(CONFIG_GCOV_KERNEL) += gcov/ obj-$(CONFIG_AUDIT_TREE) += audit_tree.o obj-$(CONFIG_KPROBES) += kprobes.o diff --git a/trunk/mm/shmem.c b/trunk/mm/shmem.c index d713239ce2ce..5f2019fc7895 100644 --- a/trunk/mm/shmem.c +++ b/trunk/mm/shmem.c @@ -1558,7 +1558,6 @@ static struct inode *shmem_get_inode(struct super_block *sb, int mode, spin_lock_init(&info->lock); info->flags = flags & VM_NORESERVE; INIT_LIST_HEAD(&info->swaplist); - cache_no_acl(inode); switch (mode & S_IFMT) { default: @@ -2380,6 +2379,10 @@ static struct inode *shmem_alloc_inode(struct super_block *sb) p = (struct shmem_inode_info *)kmem_cache_alloc(shmem_inode_cachep, GFP_KERNEL); if (!p) return NULL; +#ifdef CONFIG_TMPFS_POSIX_ACL + p->vfs_inode.i_acl = NULL; + p->vfs_inode.i_default_acl = NULL; +#endif return &p->vfs_inode; }