From f7bca0bd7c8c10fe1f906fb56c9b5bc3802978d1 Mon Sep 17 00:00:00 2001 From: Ian Abbott Date: Fri, 12 Apr 2013 13:57:54 +0100 Subject: [PATCH] --- yaml --- r: 364133 b: refs/heads/master c: fed9fd2cc6ac2b01f928bef3ce62a9d8058f514d h: refs/heads/master i: 364131: 1336004ab34f9e73c7de532f6281a113286c8cfd v: v3 --- [refs] | 2 +- trunk/drivers/staging/comedi/drivers/8255_pci.c | 15 +++++---------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/[refs] b/[refs] index 8dc576ccf2d6..ca589f3fc251 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: aee351b28ccc7b966a14c8a8e146c6b74d4717cc +refs/heads/master: fed9fd2cc6ac2b01f928bef3ce62a9d8058f514d diff --git a/trunk/drivers/staging/comedi/drivers/8255_pci.c b/trunk/drivers/staging/comedi/drivers/8255_pci.c index fff1c08a93fb..de54ad3a64e6 100644 --- a/trunk/drivers/staging/comedi/drivers/8255_pci.c +++ b/trunk/drivers/staging/comedi/drivers/8255_pci.c @@ -80,7 +80,6 @@ enum pci_8255_boardid { struct pci_8255_boardinfo { const char *name; int dio_badr; - int is_mmio; int n_8255; }; @@ -123,43 +122,36 @@ static const struct pci_8255_boardinfo pci_8255_boards[] = { [BOARD_NI_PCIDIO96] = { .name = "ni_pci-dio-96", .dio_badr = 1, - .is_mmio = 1, .n_8255 = 4, }, [BOARD_NI_PCIDIO96B] = { .name = "ni_pci-dio-96b", .dio_badr = 1, - .is_mmio = 1, .n_8255 = 4, }, [BOARD_NI_PXI6508] = { .name = "ni_pxi-6508", .dio_badr = 1, - .is_mmio = 1, .n_8255 = 4, }, [BOARD_NI_PCI6503] = { .name = "ni_pci-6503", .dio_badr = 1, - .is_mmio = 1, .n_8255 = 1, }, [BOARD_NI_PCI6503B] = { .name = "ni_pci-6503b", .dio_badr = 1, - .is_mmio = 1, .n_8255 = 1, }, [BOARD_NI_PCI6503X] = { .name = "ni_pci-6503x", .dio_badr = 1, - .is_mmio = 1, .n_8255 = 1, }, [BOARD_NI_PXI_6503] = { .name = "ni_pxi-6503", .dio_badr = 1, - .is_mmio = 1, .n_8255 = 1, }, }; @@ -187,6 +179,7 @@ static int pci_8255_auto_attach(struct comedi_device *dev, const struct pci_8255_boardinfo *board = NULL; struct pci_8255_private *devpriv; struct comedi_subdevice *s; + bool is_mmio; int ret; int i; @@ -206,7 +199,9 @@ static int pci_8255_auto_attach(struct comedi_device *dev, if (ret) return ret; - if (board->is_mmio) { + is_mmio = (pci_resource_flags(pcidev, board->dio_badr) & + IORESOURCE_MEM) != 0; + if (is_mmio) { devpriv->mmio_base = pci_ioremap_bar(pcidev, board->dio_badr); if (!devpriv->mmio_base) return -ENOMEM; @@ -227,7 +222,7 @@ static int pci_8255_auto_attach(struct comedi_device *dev, unsigned long iobase; s = &dev->subdevices[i]; - if (board->is_mmio) { + if (is_mmio) { iobase = (unsigned long)(devpriv->mmio_base + (i * 4)); ret = subdev_8255_init(dev, s, pci_8255_mmio, iobase); } else {