From fa593979e144863a1931b266ca4df01123020023 Mon Sep 17 00:00:00 2001 From: Haiyang Zhang Date: Tue, 2 Oct 2012 05:30:24 +0000 Subject: [PATCH] --- yaml --- r: 328435 b: refs/heads/master c: a3a6cab5ea10cca64d036851fe0d932448f2fe4f h: refs/heads/master i: 328433: 21c1506aa55437b270f57228ea3b39078b3cbda9 328431: 5ab4a8885298ab8d464b1455eacf8f9af58bf2c6 v: v3 --- [refs] | 2 +- trunk/drivers/net/hyperv/rndis_filter.c | 22 ++++++++++++---------- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/[refs] b/[refs] index 0cb20a36c036..0842a196fd12 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 63f6921d300c6fbdca3d0e73dcc24b4e5e4dced2 +refs/heads/master: a3a6cab5ea10cca64d036851fe0d932448f2fe4f diff --git a/trunk/drivers/net/hyperv/rndis_filter.c b/trunk/drivers/net/hyperv/rndis_filter.c index e7e12cfbbf37..928148cc3220 100644 --- a/trunk/drivers/net/hyperv/rndis_filter.c +++ b/trunk/drivers/net/hyperv/rndis_filter.c @@ -32,16 +32,19 @@ #include "hyperv_net.h" +#define RNDIS_EXT_LEN 100 struct rndis_request { struct list_head list_ent; struct completion wait_event; + struct rndis_message response_msg; /* - * FIXME: We assumed a fixed size response here. If we do ever need to - * handle a bigger response, we can either define a max response - * message or add a response buffer variable above this field + * The buffer for extended info after the RNDIS response message. It's + * referenced based on the data offset in the RNDIS message. Its size + * is enough for current needs, and should be sufficient for the near + * future. */ - struct rndis_message response_msg; + u8 response_ext[RNDIS_EXT_LEN]; /* Simplify allocation by having a netvsc packet inline */ struct hv_netvsc_packet pkt; @@ -50,12 +53,10 @@ struct rndis_request { struct rndis_message request_msg; /* - * The buffer for the extended info after the RNDIS message. It's - * referenced based on the data offset in the RNDIS message. Its size - * is enough for current needs, and should be sufficient for the near - * future. + * The buffer for the extended info after the RNDIS request message. + * It is referenced and sized in a similar way as response_ext. */ - u8 ext[100]; + u8 request_ext[RNDIS_EXT_LEN]; }; static void rndis_filter_send_completion(void *ctx); @@ -274,7 +275,8 @@ static void rndis_filter_receive_response(struct rndis_device *dev, spin_unlock_irqrestore(&dev->request_lock, flags); if (found) { - if (resp->msg_len <= sizeof(struct rndis_message)) { + if (resp->msg_len <= + sizeof(struct rndis_message) + RNDIS_EXT_LEN) { memcpy(&request->response_msg, resp, resp->msg_len); } else {