From fab31e15172e01c3932ad90230be64908ac11983 Mon Sep 17 00:00:00 2001
From: Josh Triplett <josh@joshtriplett.org>
Date: Fri, 23 Mar 2012 15:02:21 -0700
Subject: [PATCH] --- yaml --- r: 295215 b: refs/heads/master c:
 ca56dc098caf93b5437cd6c4ee49f02aa18f84d6 h: refs/heads/master i:   295213:
 e027329709a5ce74012cff96edc3c4c7bbfbbe28   295211:
 66feea7a0d5bdf0d33a9cfaffa2216199be7fe30   295207:
 8f73eae3b91d2ccb6f8a2a45c3d73e995fc7fb04   295199:
 7d43e210cbe210dbce83bef90650638f2064b5b0 v: v3

---
 [refs]                      |  2 +-
 trunk/scripts/checkpatch.pl | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/[refs] b/[refs]
index 1675e90350a2..17b5200f6713 100644
--- a/[refs]
+++ b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 6712d85852b348d07301c7480f7eb3312d329143
+refs/heads/master: ca56dc098caf93b5437cd6c4ee49f02aa18f84d6
diff --git a/trunk/scripts/checkpatch.pl b/trunk/scripts/checkpatch.pl
index 7a2f54a0bd35..de639eeeed50 100755
--- a/trunk/scripts/checkpatch.pl
+++ b/trunk/scripts/checkpatch.pl
@@ -1772,6 +1772,21 @@ sub process {
 			     "line over 80 characters\n" . $herecurr);
 		}
 
+# Check for user-visible strings broken across lines, which breaks the ability
+# to grep for the string.  Limited to strings used as parameters (those
+# following an open parenthesis), which almost completely eliminates false
+# positives, as well as warning only once per parameter rather than once per
+# line of the string.  Make an exception when the previous string ends in a
+# newline (multiple lines in one string constant) or \n\t (common in inline
+# assembly to indent the instruction on the following line).
+		if ($line =~ /^\+\s*"/ &&
+		    $prevline =~ /"\s*$/ &&
+		    $prevline =~ /\(/ &&
+		    $prevrawline !~ /\\n(?:\\t)*"\s*$/) {
+			WARN("SPLIT_STRING",
+			     "quoted string split across lines\n" . $hereprev);
+		}
+
 # check for spaces before a quoted newline
 		if ($rawline =~ /^.*\".*\s\\n/) {
 			WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE",