From fc2bcae10a7b85db79ce8d4642de798c7f1d1733 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Fri, 17 Sep 2010 20:39:22 +0200 Subject: [PATCH] --- yaml --- r: 212927 b: refs/heads/master c: 01b284f9b6d51cc3f3bcf3b49f16d2601d3ca22d h: refs/heads/master i: 212925: 3edcdb65c24a029561720e1461510a2ef21b78f7 212923: bf74e6b7e2827de9bbc90cce46c4746990e3fd28 212919: 8ab49a92fc523ce958767baacc7ed3095927fdb2 212911: f5f912698bf2b5e0acdbd896693a16899bdd7fff 212895: fe885838ec0d5108a88ca6942c52a3a77d778584 212863: b277bf504bfe0c2b0dd3d764f8d3af413fd4eebb v: v3 --- [refs] | 2 +- trunk/kernel/trace/blktrace.c | 14 +++----------- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/[refs] b/[refs] index d688f459661d..d16fbdb32d98 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/master: 0fc86c7bd924debd0bddee790ecc884604fdcc63 +refs/heads/master: 01b284f9b6d51cc3f3bcf3b49f16d2601d3ca22d diff --git a/trunk/kernel/trace/blktrace.c b/trunk/kernel/trace/blktrace.c index 959f8d6c8cc1..5328e8779d4d 100644 --- a/trunk/kernel/trace/blktrace.c +++ b/trunk/kernel/trace/blktrace.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include @@ -639,7 +638,6 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg) if (!q) return -ENXIO; - lock_kernel(); mutex_lock(&bdev->bd_mutex); switch (cmd) { @@ -667,7 +665,6 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg) } mutex_unlock(&bdev->bd_mutex); - unlock_kernel(); return ret; } @@ -1652,10 +1649,9 @@ static ssize_t sysfs_blk_trace_attr_show(struct device *dev, struct block_device *bdev; ssize_t ret = -ENXIO; - lock_kernel(); bdev = bdget(part_devt(p)); if (bdev == NULL) - goto out_unlock_kernel; + goto out; q = blk_trace_get_queue(bdev); if (q == NULL) @@ -1683,8 +1679,7 @@ static ssize_t sysfs_blk_trace_attr_show(struct device *dev, mutex_unlock(&bdev->bd_mutex); out_bdput: bdput(bdev); -out_unlock_kernel: - unlock_kernel(); +out: return ret; } @@ -1714,11 +1709,10 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev, ret = -ENXIO; - lock_kernel(); p = dev_to_part(dev); bdev = bdget(part_devt(p)); if (bdev == NULL) - goto out_unlock_kernel; + goto out; q = blk_trace_get_queue(bdev); if (q == NULL) @@ -1753,8 +1747,6 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev, mutex_unlock(&bdev->bd_mutex); out_bdput: bdput(bdev); -out_unlock_kernel: - unlock_kernel(); out: return ret ? ret : count; }