Skip to content

Infrastructural changes #13

Merged
merged 4 commits into from Sep 20, 2019
Merged

Infrastructural changes #13

merged 4 commits into from Sep 20, 2019

Conversation

jenzopr
Copy link
Member

@jenzopr jenzopr commented Sep 5, 2019

Here, I will collect commits that change the infrastructure of the repository a bit 😉

@jenzopr
Copy link
Member Author

jenzopr commented Sep 6, 2019

Details

  • I updated the README file to contain less information and more structure. Especially, I put the focus on How to get the app running and How to get my data into it (see 9219fb3)
  • I cleaned up the Dockerfile and made it much simpler. Now, it is based on the rocker/shiny image and we do not need to install shiny ourselves any more. A feature of the new image is that it is configurable using env variables during docker run. For example, using docker run -e WILSON_LANDING_PAGE='feature_selection' will directly show the Feature Selection page of Wilson (see 89a0211 and 6f4c744).
  • I moved the location of the Dockerfiles into the wilson-basic folder. This removes the necessity to clone and download the Wilson-Apps repository during docker build. The workflow to build the container is now git clone; cd wilson-basic; docker build . (see 89a0211).
  • Custom data is easily included in the container by moving it into the data subdirectory. Mounting a external_data directory is still possible (see 89a0211).
  • Although I removed old Docker files, they are still available in the Backup Release.
  • I implemented jinja2 templating for the Shiny server configuration and the app configuration, which enables container customarization during docker run. This can easily be extended to more variables (see 6f4c744 and 89a0211).

Copy link
Contributor

@ckuenne ckuenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me. but including jinja for one and a half parameter seems a bit overdeveloped to me. :)

@jenzopr
Copy link
Member Author

jenzopr commented Sep 9, 2019

I agree - however, it allows to integrate much more parameters (e.g. logging) to be controlled from outside the container..

@jenzopr jenzopr merged commit 4ea6bd3 into master Sep 20, 2019
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants