Update keepassxc from 2.2.2 to 2.4.1 #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmenzel
reviewed
Apr 17, 2019
argon2.be0
Outdated
| #} | ||
|
|
||
| mee_build() { | ||
| make libs DESTDIR=${D} |
There was a problem hiding this comment.
Why are you not building the binary argon2? Is it too big? That would also simplify the build script.
|
because it is build
bee query argon2-20171227-0.x86_64
/usr/include/argon2.h
/usr/lib/libargon2.so.1
/usr/lib/libargon2.a
/usr/lib/libargon2.so//libargon2.so.1
/usr/lib/pkgconfig/libargon2.pc
/usr/bin/argon2
when you make a 'normal' make, you get 3 other binaries extra.
…On 04/17/19 11:02, Paul Menzel wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In argon2.be0
<#1073 (comment)>:
> +
+
+#mee_extract() {
+# bee_extract "${@}"
+#}
+
+#mee_patch() {
+# bee_patch "${@}"
+#}
+
+#mee_configure() {
+# bee_configure
+#}
+
+mee_build() {
+ make libs DESTDIR=${D}
Why are you not building the binary |argon2|? Is it too big? That
would also simplify the build script.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub Enterprise
<#1073 (review)>,
or mute the thread
<https://github.molgen.mpg.de/notifications/unsubscribe-auth/AAAAkNtGQVYEuctJqEmesLO3WI5ALQ_Mks5vhuNAgaJpZM0XxA==>.
--
IT-Abteilung
Max-Planck-Institut fuer Molekulare Genetik
Fon: -1105
Email: schrader@molgen.mpg.de
|
|
I think, the binary is built during bee_install, because the makefile has the required dependencies. The default bee_build would do and the executable would be build in the build phase, not in the install phase, with feels a bit better. But in the build log it says "Building with optimizations for native" and I see "gcc -march=native" which might be a bit dangerous. Looking at the Makefile, I see that a generic version can be produced by setting OPTTARGET to something which the compiler doesn't accept on -march . So I suggest |
Argon2 is a password-hashing function, which keepasxc need.
needs for browser support of keepassxc
add browser support Request from Sven Klages helpdesk 11.4.19 MariuX: KeePassXC 2.4
david
force-pushed
the
update-keepassxc-from-2.2.2-to-2.4.1
branch
from
ec55b15
to
1cc4794
Compare
|
Thanks I have update it and also add it to bee_install |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.