Skip to content
Jump to bottom

clamav: fix unit test race condition #2630

Merged
merged 1 commit into from
Apr 13, 2022
Merged

clamav: fix unit test race condition #2630

merged 1 commit into from
Apr 13, 2022

Commits on Apr 13, 2022

  1. clamav: fix unit test race condition 

    - fixed.

Wenn die unit tests laufen, versucht
   `clamav-0.104.2-0/source/unit_tests/input/xor_testfile.py`
den Folder `"build/unit_tests/input/clamav_hdb_scanfiles"` zu erstellen, der aber schon existiert.

im xor_testfile.py:55 wir erst ein mkdir(), dann ein open/write/close gemacht, innerhalb eines try:-blocks

```
[  0%] Decrypting test file clam-v3.rar...
cd PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input && /usr/local/package/bin/python3.8 PREFIX/buildroot/clamav/clamav-0.104.2-0/source/unit_tests/input/xor_testfile.py --in_file PREFIX/buildroot/clamav/clamav-0.104.2-0/source/unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar.xor --out_file PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar

Failed to create file: PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar. Exception: [Errno 17] File exists: 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input/clamav_hdb_scanfiles'

make[2]: *** [unit_tests/input/CMakeFiles/tgt_clam-v3.rar.dir/build.make:64: unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar] Error 1
make[2]: Leaving directory 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build'
make[2]: Entering directory 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build'

versus

[  0%] Decrypting test file clam-v3.rar...
cd PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input && /usr/bin/python3 PREFIX/buildroot/clamav/clamav-0.104.2-0/source/unit_tests/input/xor_testfile.py --in_file PREFIX/buildroot/clamav/clamav-0.104.2-0/source/unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar.xor --out_file PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar
Created: 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar'
make[2]: Leaving directory 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build'
make[1]: Entering directory 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build'
[  1%] Built target tgt_clam_cache_emax.tgz
make[1]: Leaving directory 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build'
make[1]: Entering directory 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build'
[  2%] Built target tgt_clam-v3.rar
```
    @wwwutz
    wwwutz committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    71a898f View commit details
    Browse the repository at this point in the history