From 178e146d52973569644e877eba5243b56884744a Mon Sep 17 00:00:00 2001 From: Donald Buczek Date: Mon, 11 Sep 2023 09:23:33 +0200 Subject: [PATCH] beesh: Abort if download fails Currently, bee doesn't detect the situation when a partial file is downloaded. An incomplete archive usually makes the following extract to fail, but the broken file is kept in the cache an needs to be removed manually. The situation, when a failed download produces an empty file, is already handled. Empty cache files are removed when bee is run the next time. Currently, bee contains explicit code to ignore errors from wget. This code existed in the initial commit 067ccf2 ("initial revision") from 2010. The reasoning is unclear today and has to be rediscovered if it's still valid. So this patch is kind of experimental and might need to be undone. Remove code to explicitly ignore wget failures. As the script is running with `-e`, a wget failure should invoke the EXIT trap, which removes the incomplete file. This is untested. --- src/beesh.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/beesh.sh.in b/src/beesh.sh.in index d02faa4..feb602e 100644 --- a/src/beesh.sh.in +++ b/src/beesh.sh.in @@ -286,7 +286,7 @@ function fetch_one_file() { --no-clobber \ --timeout=60 \ --tries=1 \ - "${url}" || true + "${url}" trap - EXIT