Skip to content

Commit

Permalink
ehea: Use DEVICE_ATTR_*() macro
Browse files Browse the repository at this point in the history
Use DEVICE_ATTR_*() helper instead of plain DEVICE_ATTR,
which makes the code a bit shorter and easier to read.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
YueHaibing authored and David S. Miller committed May 24, 2021
1 parent 4934fb7 commit 0056982
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions drivers/net/ethernet/ibm/ehea/ehea_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2867,14 +2867,14 @@ static int ehea_get_jumboframe_status(struct ehea_port *port, int *jumbo)
return ret;
}

static ssize_t ehea_show_port_id(struct device *dev,
struct device_attribute *attr, char *buf)
static ssize_t log_port_id_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct ehea_port *port = container_of(dev, struct ehea_port, ofdev.dev);
return sprintf(buf, "%d", port->logical_port_id);
}

static DEVICE_ATTR(log_port_id, 0444, ehea_show_port_id, NULL);
static DEVICE_ATTR_RO(log_port_id);

static void logical_port_release(struct device *dev)
{
Expand Down Expand Up @@ -3113,7 +3113,7 @@ static struct device_node *ehea_get_eth_dn(struct ehea_adapter *adapter,
return NULL;
}

static ssize_t ehea_probe_port(struct device *dev,
static ssize_t probe_port_store(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
{
Expand Down Expand Up @@ -3168,9 +3168,9 @@ static ssize_t ehea_probe_port(struct device *dev,
return (ssize_t) count;
}

static ssize_t ehea_remove_port(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
static ssize_t remove_port_store(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
{
struct ehea_adapter *adapter = dev_get_drvdata(dev);
struct ehea_port *port;
Expand Down Expand Up @@ -3203,8 +3203,8 @@ static ssize_t ehea_remove_port(struct device *dev,
return (ssize_t) count;
}

static DEVICE_ATTR(probe_port, 0200, NULL, ehea_probe_port);
static DEVICE_ATTR(remove_port, 0200, NULL, ehea_remove_port);
static DEVICE_ATTR_WO(probe_port);
static DEVICE_ATTR_WO(remove_port);

static int ehea_create_device_sysfs(struct platform_device *dev)
{
Expand Down

0 comments on commit 0056982

Please sign in to comment.