Skip to content

Commit

Permalink
staging: silicom: Remove needless calls of get_status_port_fn()
Browse files Browse the repository at this point in the history
Remove a needless pointer initialisation and call to get_status_port_fn()
in functions remove_bypass_tpl_auto() and set_tpl_fn(). Variable
'pbpctl_dev_b' is set correctly later in the function before first use.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Christian Engelmayer authored and Greg Kroah-Hartman committed May 23, 2014
1 parent ea3528c commit 01cda8d
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/staging/silicom/bpctl_mod.c
Original file line number Diff line number Diff line change
Expand Up @@ -4735,10 +4735,9 @@ static void bp_tpl_timer_fn(unsigned long param)

static void remove_bypass_tpl_auto(struct bpctl_dev *pbpctl_dev)
{
struct bpctl_dev *pbpctl_dev_b = NULL;
struct bpctl_dev *pbpctl_dev_b;
if (!pbpctl_dev)
return;
pbpctl_dev_b = get_status_port_fn(pbpctl_dev);

if (pbpctl_dev->bp_caps & TPL_CAP) {
del_timer_sync(&pbpctl_dev->bp_tpl_timer);
Expand Down Expand Up @@ -4785,12 +4784,10 @@ static int set_bypass_tpl_auto(struct bpctl_dev *pbpctl_dev, unsigned int param)
static int set_tpl_fn(struct bpctl_dev *pbpctl_dev, int tpl_mode)
{

struct bpctl_dev *pbpctl_dev_b = NULL;
struct bpctl_dev *pbpctl_dev_b;
if (!pbpctl_dev)
return -1;

pbpctl_dev_b = get_status_port_fn(pbpctl_dev);

if (pbpctl_dev->bp_caps & TPL_CAP) {
if (tpl_mode) {
pbpctl_dev_b = get_status_port_fn(pbpctl_dev);
Expand Down

0 comments on commit 01cda8d

Please sign in to comment.