Skip to content

Commit

Permalink
Btrfs: make the cleaner complete early when the fs is going to be umo…
Browse files Browse the repository at this point in the history
…unted

Cc: David Sterba <dsterba@suse.cz>
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
  • Loading branch information
Miao Xie authored and Josef Bacik committed Jun 14, 2013
1 parent d027824 commit 05323cd
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions fs/btrfs/disk-io.c
Original file line number Diff line number Diff line change
Expand Up @@ -1674,12 +1674,14 @@ static void end_workqueue_fn(struct btrfs_work *work)
}

/*
* If we remount the fs to be R/O, the cleaner needn't do anything except
* sleeping. This function is used to check the status of the fs.
* If we remount the fs to be R/O or umount the fs, the cleaner needn't do
* anything except sleeping. This function is used to check the status of
* the fs.
*/
static inline int need_cleaner_sleep(struct btrfs_root *root)
{
return root->fs_info->sb->s_flags & MS_RDONLY;
return (root->fs_info->sb->s_flags & MS_RDONLY ||
btrfs_fs_closing(root->fs_info));
}

static int cleaner_kthread(void *arg)
Expand All @@ -1702,8 +1704,8 @@ static int cleaner_kthread(void *arg)
mutex_unlock(&root->fs_info->cleaner_mutex);

/*
* The defragger has dealt with the R/O remount, needn't
* do anything special here.
* The defragger has dealt with the R/O remount and umount,
* needn't do anything special here.
*/
btrfs_run_defrag_inodes(root->fs_info);
sleep:
Expand Down

0 comments on commit 05323cd

Please sign in to comment.