Skip to content

Commit

Permalink
perf ui/tui: Print helpline message as is
Browse files Browse the repository at this point in the history
When a tip message contains a percent sign, it was treated printf format
specifier so broken string was printed like below.

  Tip: Limit to show entries above 577nly: perf report --percent-limit 5
                                   ^^^

As ui_browser__show receives format string, pass additional "%s" so that
the help (tip) message can be printed as is.

  Tip: Limit to show entries above 5% only: perf report --percent-limit 5

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1452509594-13616-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Namhyung Kim authored and Arnaldo Carvalho de Melo committed Jan 12, 2016
1 parent 84cfac7 commit 090cff3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/perf/ui/browsers/hists.c
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ static int hist_browser__run(struct hist_browser *browser, const char *help)

hists__browser_title(browser->hists, hbt, title, sizeof(title));

if (ui_browser__show(&browser->b, title, help) < 0)
if (ui_browser__show(&browser->b, title, "%s", help) < 0)
return -1;

while (1) {
Expand Down

0 comments on commit 090cff3

Please sign in to comment.