Skip to content

Commit

Permalink
spidernet: revise link status logging
Browse files Browse the repository at this point in the history
This patch revises the logging for link informations of spidernet.

  - The link down message is too verbose because auto-negotiation timeout
    occurs periodically while an ethernet cable is not connected.
  - We want to see the link result, and we think it should be displayed.

Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Acked-by: Jens Osterkamp <jens@de.ibm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Ishizaki Kou authored and Jeff Garzik committed Apr 17, 2008
1 parent 9a11fcb commit 0b50d75
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions drivers/net/spider_net.c
Original file line number Diff line number Diff line change
Expand Up @@ -2045,7 +2045,8 @@ static void spider_net_link_phy(unsigned long data)
/* if link didn't come up after SPIDER_NET_ANEG_TIMEOUT tries, setup phy again */
if (card->aneg_count > SPIDER_NET_ANEG_TIMEOUT) {

pr_info("%s: link is down trying to bring it up\n", card->netdev->name);
pr_debug("%s: link is down trying to bring it up\n",
card->netdev->name);

switch (card->medium) {
case BCM54XX_COPPER:
Expand Down Expand Up @@ -2096,9 +2097,10 @@ static void spider_net_link_phy(unsigned long data)

card->aneg_count = 0;

pr_debug("Found %s with %i Mbps, %s-duplex %sautoneg.\n",
phy->def->name, phy->speed, phy->duplex==1 ? "Full" : "Half",
phy->autoneg==1 ? "" : "no ");
pr_info("%s: link up, %i Mbps, %s-duplex %sautoneg.\n",
card->netdev->name, phy->speed,
phy->duplex == 1 ? "Full" : "Half",
phy->autoneg == 1 ? "" : "no ");

return;
}
Expand Down

0 comments on commit 0b50d75

Please sign in to comment.