Skip to content

Commit

Permalink
Merge tag 'linux-can-fixes-for-4.10-20170130' of git://git.kernel.org…
Browse files Browse the repository at this point in the history
…/pub/scm/linux/kernel/git/mkl/linux-can

Marc Kleine-Budde says:

====================
pull-request: can 2017-01-30

this is a pull request of one patch.

The patch is by Oliver Hartkopp and fixes the hrtimer/tasklet termination in
bcm op removal.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Jan 30, 2017
2 parents 2b89ed6 + a06393e commit 0d29ed2
Showing 1 changed file with 16 additions and 7 deletions.
23 changes: 16 additions & 7 deletions net/can/bcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -734,14 +734,23 @@ static struct bcm_op *bcm_find_op(struct list_head *ops,

static void bcm_remove_op(struct bcm_op *op)
{
hrtimer_cancel(&op->timer);
hrtimer_cancel(&op->thrtimer);

if (op->tsklet.func)
tasklet_kill(&op->tsklet);
if (op->tsklet.func) {
while (test_bit(TASKLET_STATE_SCHED, &op->tsklet.state) ||
test_bit(TASKLET_STATE_RUN, &op->tsklet.state) ||
hrtimer_active(&op->timer)) {
hrtimer_cancel(&op->timer);
tasklet_kill(&op->tsklet);
}
}

if (op->thrtsklet.func)
tasklet_kill(&op->thrtsklet);
if (op->thrtsklet.func) {
while (test_bit(TASKLET_STATE_SCHED, &op->thrtsklet.state) ||
test_bit(TASKLET_STATE_RUN, &op->thrtsklet.state) ||
hrtimer_active(&op->thrtimer)) {
hrtimer_cancel(&op->thrtimer);
tasklet_kill(&op->thrtsklet);
}
}

if ((op->frames) && (op->frames != &op->sframe))
kfree(op->frames);
Expand Down

0 comments on commit 0d29ed2

Please sign in to comment.