From 3116a9931fa6fa067986a2cb0cc447c58530b1f0 Mon Sep 17 00:00:00 2001 From: Baolin Wang Date: Mon, 1 Jun 2020 14:05:52 +0800 Subject: [PATCH 1/4] hwspinlock: sprd: Remove redundant header files Remove redundant header files. Signed-off-by: Baolin Wang Link: https://lore.kernel.org/r/1590991552-93643-1-git-send-email-baolin.wang@linux.alibaba.com Signed-off-by: Bjorn Andersson --- drivers/hwspinlock/sprd_hwspinlock.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c index 36dc8038bbb4e..b1574953d95fc 100644 --- a/drivers/hwspinlock/sprd_hwspinlock.c +++ b/drivers/hwspinlock/sprd_hwspinlock.c @@ -4,7 +4,6 @@ * Copyright (C) 2017 Spreadtrum - http://www.spreadtrum.com */ -#include #include #include #include @@ -15,7 +14,6 @@ #include #include #include -#include #include "hwspinlock_internal.h" From 8308678ebde1cbca9fb628ba2e7b6e4ea0b15acf Mon Sep 17 00:00:00 2001 From: Chunyan Zhang Date: Fri, 30 Oct 2020 11:46:54 +0800 Subject: [PATCH 2/4] hwspinlock: sprd: use module_platform_driver() instead postcore initcall The hardware spinlock devices are defined in the DT, there's no need for init calls order, remove boilerplate code by using module_platform_driver. Reviewed-by: Baolin Wang Signed-off-by: Chunyan Zhang Link: https://lore.kernel.org/r/20201030034654.15775-3-zhang.lyra@gmail.com Signed-off-by: Bjorn Andersson --- drivers/hwspinlock/sprd_hwspinlock.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c index b1574953d95fc..95f680a4c0286 100644 --- a/drivers/hwspinlock/sprd_hwspinlock.c +++ b/drivers/hwspinlock/sprd_hwspinlock.c @@ -149,18 +149,7 @@ static struct platform_driver sprd_hwspinlock_driver = { .of_match_table = of_match_ptr(sprd_hwspinlock_of_match), }, }; - -static int __init sprd_hwspinlock_init(void) -{ - return platform_driver_register(&sprd_hwspinlock_driver); -} -postcore_initcall(sprd_hwspinlock_init); - -static void __exit sprd_hwspinlock_exit(void) -{ - platform_driver_unregister(&sprd_hwspinlock_driver); -} -module_exit(sprd_hwspinlock_exit); +module_platform_driver(sprd_hwspinlock_driver); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("Hardware spinlock driver for Spreadtrum"); From 8266b809264caa23038ceab2811fc452cf936e84 Mon Sep 17 00:00:00 2001 From: Chunyan Zhang Date: Thu, 12 Nov 2020 15:04:10 +0800 Subject: [PATCH 3/4] hwspinlock: sprd: fixed warning of unused variable 'sprd_hwspinlock_of_match' The macro function of_match_ptr() is NULL if CONFIG_OF is not set, in this case Clang compiler would complain the of_device_id variable is unused. Reviewed-by: Baolin Wang Reported-by: kernel test robot Fixes: d8c8bbbb1aba ("hwspinlock: sprd: Add hardware spinlock driver") Signed-off-by: Chunyan Zhang Link: https://lore.kernel.org/r/20201112070410.14810-1-zhang.lyra@gmail.com Signed-off-by: Bjorn Andersson --- drivers/hwspinlock/sprd_hwspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c index 95f680a4c0286..d221fc9d756d6 100644 --- a/drivers/hwspinlock/sprd_hwspinlock.c +++ b/drivers/hwspinlock/sprd_hwspinlock.c @@ -146,7 +146,7 @@ static struct platform_driver sprd_hwspinlock_driver = { .probe = sprd_hwspinlock_probe, .driver = { .name = "sprd_hwspinlock", - .of_match_table = of_match_ptr(sprd_hwspinlock_of_match), + .of_match_table = sprd_hwspinlock_of_match, }, }; module_platform_driver(sprd_hwspinlock_driver); From c3e9b463b41b45c4556a13043265097e2184226e Mon Sep 17 00:00:00 2001 From: Baolin Wang Date: Mon, 8 Jun 2020 20:20:28 +0800 Subject: [PATCH 4/4] hwspinlock: sirf: Remove the redundant 'of_match_ptr' Remove the the redundant 'of_match_ptr' macro to fix below warning when the CONFIG_OF is not selected. All warnings: drivers/hwspinlock/sirf_hwspinlock.c:87:34: warning: unused variable 'sirf_hwpinlock_ids' [-Wunused-const-variable] Reported-by: kernel test robot Signed-off-by: Baolin Wang Link: https://lore.kernel.org/r/250d35cb489c3c4c066f7ce256d27f36712a1979.1591618255.git.baolin.wang7@gmail.com Signed-off-by: Bjorn Andersson --- drivers/hwspinlock/sirf_hwspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwspinlock/sirf_hwspinlock.c b/drivers/hwspinlock/sirf_hwspinlock.c index 823d3c4f621ed..a3f77120bad76 100644 --- a/drivers/hwspinlock/sirf_hwspinlock.c +++ b/drivers/hwspinlock/sirf_hwspinlock.c @@ -94,7 +94,7 @@ static struct platform_driver sirf_hwspinlock_driver = { .probe = sirf_hwspinlock_probe, .driver = { .name = "atlas7_hwspinlock", - .of_match_table = of_match_ptr(sirf_hwpinlock_ids), + .of_match_table = sirf_hwpinlock_ids, }, };