Skip to content

Commit

Permalink
mailbox/xgene-slimpro: Checking for IS_ERR instead of NULL
Browse files Browse the repository at this point in the history
devm_ioremap() returns NULL, it never returns an ERR_PTR.

Fixes: f700e84 ('mailbox: Add support for APM X-Gene platform mailbox driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
  • Loading branch information
Dan Carpenter authored and Jassi Brar committed Mar 4, 2016
1 parent 9c38418 commit 14d653a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/mailbox/mailbox-xgene-slimpro.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,8 @@ static int slimpro_mbox_probe(struct platform_device *pdev)

regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
mb_base = devm_ioremap(&pdev->dev, regs->start, resource_size(regs));
if (IS_ERR(mb_base))
return PTR_ERR(mb_base);
if (!mb_base)
return -ENOMEM;

/* Setup mailbox links */
for (i = 0; i < MBOX_CNT; i++) {
Expand Down

0 comments on commit 14d653a

Please sign in to comment.