Skip to content

Commit

Permalink
thinkpad-acpi: drop HKEY event 0x5010
Browse files Browse the repository at this point in the history
HKEY event 0x5010 is useless to us: old ThinkPads don't issue it.  Newer
ThinkPads won't issue it anymore.  And all ThinkPads issue 0x1010 and
0x1011 events.

Just silently drop it instead of sending it to userspace.

Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Henrique de Moraes Holschuh authored and Len Brown committed Sep 20, 2009
1 parent 4be7300 commit 176dd98
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Documentation/laptops/thinkpad-acpi.txt
Original file line number Diff line number Diff line change
Expand Up @@ -525,14 +525,14 @@ compatibility purposes when hotkey_report_mode is set to 1.
0x2305 System is waking up from suspend to eject bay
0x2404 System is waking up from hibernation to undock
0x2405 System is waking up from hibernation to eject bay
0x5010 Brightness level changed/control event

The above events are never propagated by the driver.

0x3003 Bay ejection (see 0x2x05) complete, can sleep again
0x4003 Undocked (see 0x2x04), can sleep again
0x500B Tablet pen inserted into its storage bay
0x500C Tablet pen removed from its storage bay
0x5010 Brightness level changed (newer Lenovo BIOSes)

The above events are propagated by the driver.

Expand Down
8 changes: 4 additions & 4 deletions drivers/platform/x86/thinkpad_acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -3305,7 +3305,6 @@ static bool hotkey_notify_usrevent(const u32 hkey,
*ignore_acpi_ev = false;

switch (hkey) {
case 0x5010: /* Lenovo new BIOS: brightness changed */
case 0x500b: /* X61t: tablet pen inserted into bay */
case 0x500c: /* X61t: tablet pen removed from bay */
return true;
Expand All @@ -3317,9 +3316,10 @@ static bool hotkey_notify_usrevent(const u32 hkey,
*send_acpi_ev = false;
return true;

case 0x5001:
case 0x5002:
/* LID switch events. Do not propagate */
case 0x5001: /* Lid close */
case 0x5002: /* Lid open */
case 0x5010: /* brightness control */
/* do not propagate these events */
*ignore_acpi_ev = true;
return true;

Expand Down

0 comments on commit 176dd98

Please sign in to comment.