Skip to content

Commit

Permalink
selftests/resctrl: Return MBA check result and make it to output message
Browse files Browse the repository at this point in the history
Since MBA check result is not returned, the MBA test result message
is always output as "ok" regardless of whether the MBA check result is
true or false.

Make output message to be "not ok" if MBA check result is failed.

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
  • Loading branch information
Shaopeng Tan authored and Shuah Khan committed Apr 13, 2023
1 parent 42e3b09 commit 1e359b6
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions tools/testing/selftests/resctrl/mba_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ static int mba_setup(int num, ...)
return 0;
}

static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc)
static bool show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc)
{
int allocation, runs;
bool failed = false;
bool ret = false;

ksft_print_msg("Results are displayed in (MB)\n");
/* Memory bandwidth from 100% down to 10% */
Expand Down Expand Up @@ -95,13 +95,15 @@ static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc)
ksft_print_msg("avg_bw_imc: %lu\n", avg_bw_imc);
ksft_print_msg("avg_bw_resc: %lu\n", avg_bw_resc);
if (avg_diff_per > MAX_DIFF_PERCENT)
failed = true;
ret = true;
}

ksft_print_msg("%s Check schemata change using MBA\n",
failed ? "Fail:" : "Pass:");
if (failed)
ret ? "Fail:" : "Pass:");
if (ret)
ksft_print_msg("At least one test failed\n");

return ret;
}

static int check_results(void)
Expand Down Expand Up @@ -137,9 +139,7 @@ static int check_results(void)

fclose(fp);

show_mba_info(bw_imc, bw_resc);

return 0;
return show_mba_info(bw_imc, bw_resc);
}

void mba_test_cleanup(void)
Expand Down

0 comments on commit 1e359b6

Please sign in to comment.