From 1ed418e6265c0fd05a5bf12cddf01b38b6fa3750 Mon Sep 17 00:00:00 2001 From: Aaron Ma <aaron.ma@canonical.com> Date: Mon, 19 Jul 2021 17:07:01 +0800 Subject: [PATCH] mt76: mt7921: continue to probe driver when fw already downloaded BugLink: https://bugs.launchpad.net/bugs/1936790 When reboot system, no power cycles, firmware is already downloaded, return -EIO will break driver as error: mt7921e: probe of 0000:03:00.0 failed with error -5 Skip firmware download and continue to probe. Signed-off-by: Aaron Ma <aaron.ma@canonical.com> Fixes: 1c099ab44727c ("mt76: mt7921: add MCU support") Signed-off-by: David S. Miller <davem@davemloft.net> (cherry picked from commit c34269041185dad1bab7a34f42ef9fab967a1684) Signed-off-by: Aaron Ma <aaron.ma@canonical.com> Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com> --- drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c index 67dc4b4cc0945..f7459ad2a0738 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c @@ -910,7 +910,7 @@ static int mt7921_load_firmware(struct mt7921_dev *dev) ret = mt76_get_field(dev, MT_CONN_ON_MISC, MT_TOP_MISC2_FW_N9_RDY); if (ret) { dev_dbg(dev->mt76.dev, "Firmware is already download\n"); - return -EIO; + goto fw_loaded; } ret = mt7921_load_patch(dev); @@ -928,6 +928,7 @@ static int mt7921_load_firmware(struct mt7921_dev *dev) return -EIO; } +fw_loaded: mt76_queue_tx_cleanup(dev, dev->mt76.q_mcu[MT_MCUQ_FWDL], false); #ifdef CONFIG_PM