Skip to content

Commit

Permalink
net: ethtool: Monotonically increase the message sequence number
Browse files Browse the repository at this point in the history
Currently, during the module firmware flashing process, unicast
notifications are sent from the kernel using the same sequence number,
making it impossible for user space to track missed notifications.

Monotonically increase the message sequence number, so the order of
notifications could be tracked effectively.

Signed-off-by: Danielle Ratson <danieller@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20240711080934.2071869-1-danieller@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Danielle Ratson authored and Jakub Kicinski committed Jul 13, 2024
1 parent 646d2ac commit 275a63c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ethtool/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ ethnl_module_fw_flash_ntf(struct net_device *dev,
if (!skb)
return;

hdr = ethnl_unicast_put(skb, ntf_params->portid, ntf_params->seq,
hdr = ethnl_unicast_put(skb, ntf_params->portid, ++ntf_params->seq,
ETHTOOL_MSG_MODULE_FW_FLASH_NTF);
if (!hdr)
goto err_skb;
Expand Down

0 comments on commit 275a63c

Please sign in to comment.