Skip to content

Commit

Permalink
drm/bridge: imx8mp-hdmi-pvi: Convert to platform remove callback retu…
Browse files Browse the repository at this point in the history
…rning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240304090555.716327-2-u.kleine-koenig@pengutronix.de
  • Loading branch information
Uwe Kleine-König authored and Robert Foss committed Apr 10, 2024
1 parent fb24c13 commit 29b3967
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,13 @@ static int imx8mp_hdmi_pvi_probe(struct platform_device *pdev)
return 0;
}

static int imx8mp_hdmi_pvi_remove(struct platform_device *pdev)
static void imx8mp_hdmi_pvi_remove(struct platform_device *pdev)
{
struct imx8mp_hdmi_pvi *pvi = platform_get_drvdata(pdev);

drm_bridge_remove(&pvi->bridge);

pm_runtime_disable(&pdev->dev);

return 0;
}

static const struct of_device_id imx8mp_hdmi_pvi_match[] = {
Expand All @@ -195,7 +193,7 @@ MODULE_DEVICE_TABLE(of, imx8mp_hdmi_pvi_match);

static struct platform_driver imx8mp_hdmi_pvi_driver = {
.probe = imx8mp_hdmi_pvi_probe,
.remove = imx8mp_hdmi_pvi_remove,
.remove_new = imx8mp_hdmi_pvi_remove,
.driver = {
.name = "imx-hdmi-pvi",
.of_match_table = imx8mp_hdmi_pvi_match,
Expand Down

0 comments on commit 29b3967

Please sign in to comment.