From 2b7950c7ac9117a18f1790fcea819cb69380e5bd Mon Sep 17 00:00:00 2001 From: Sergey Shtylyov Date: Thu, 27 Jan 2022 22:44:25 +0300 Subject: [PATCH] power: supply: mp2629_charger: use platform_get_irq() Calling platform_get_irq_optional() doesn't make sense if you then bail out on any error it returns. Switch to calling platform_get_irq() instead and remove dev_err() call as platform_get_irq() already curses loudly on error. Signed-off-by: Sergey Shtylyov Signed-off-by: Sebastian Reichel --- drivers/power/supply/mp2629_charger.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/mp2629_charger.c b/drivers/power/supply/mp2629_charger.c index bdf924b73e478..bf9c27b463a80 100644 --- a/drivers/power/supply/mp2629_charger.c +++ b/drivers/power/supply/mp2629_charger.c @@ -580,11 +580,9 @@ static int mp2629_charger_probe(struct platform_device *pdev) charger->dev = dev; platform_set_drvdata(pdev, charger); - irq = platform_get_irq_optional(to_platform_device(dev->parent), 0); - if (irq < 0) { - dev_err(dev, "get irq fail: %d\n", irq); + irq = platform_get_irq(to_platform_device(dev->parent), 0); + if (irq < 0) return irq; - } for (i = 0; i < MP2629_MAX_FIELD; i++) { charger->regmap_fields[i] = devm_regmap_field_alloc(dev,