Skip to content

Commit

Permalink
media: dvb-frontends: Use kmemdup instead of duplicating its function
Browse files Browse the repository at this point in the history
kmemdup has implemented the function that kmalloc() + memcpy().
We prefer to kmemdup rather than code opened implementation.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
  • Loading branch information
zhong jiang authored and Mauro Carvalho Chehab committed Dec 3, 2018
1 parent 73f847a commit 2c4746c
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/media/dvb-frontends/lgdt3306a.c
Original file line number Diff line number Diff line change
Expand Up @@ -2205,15 +2205,13 @@ static int lgdt3306a_probe(struct i2c_client *client,
struct dvb_frontend *fe;
int ret;

config = kzalloc(sizeof(struct lgdt3306a_config), GFP_KERNEL);
config = kmemdup(client->dev.platform_data,
sizeof(struct lgdt3306a_config), GFP_KERNEL);
if (config == NULL) {
ret = -ENOMEM;
goto fail;
}

memcpy(config, client->dev.platform_data,
sizeof(struct lgdt3306a_config));

config->i2c_addr = client->addr;
fe = lgdt3306a_attach(config, client->adapter);
if (fe == NULL) {
Expand Down

0 comments on commit 2c4746c

Please sign in to comment.