Skip to content

Commit

Permalink
random: initialize the non-blocking pool via add_hwgenerator_randomne…
Browse files Browse the repository at this point in the history
…ss()

If we have a hardware RNG and are using the in-kernel rngd, we should
use this to initialize the non-blocking pool so that getrandom(2)
doesn't block unnecessarily.

Cc: stable@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
  • Loading branch information
Theodore Ts'o committed Jun 13, 2016
1 parent 1a695a9 commit 3371f3d
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions drivers/char/random.c
Original file line number Diff line number Diff line change
Expand Up @@ -1849,12 +1849,18 @@ void add_hwgenerator_randomness(const char *buffer, size_t count,
{
struct entropy_store *poolp = &input_pool;

/* Suspend writing if we're above the trickle threshold.
* We'll be woken up again once below random_write_wakeup_thresh,
* or when the calling thread is about to terminate.
*/
wait_event_interruptible(random_write_wait, kthread_should_stop() ||
if (unlikely(nonblocking_pool.initialized == 0))
poolp = &nonblocking_pool;
else {
/* Suspend writing if we're above the trickle
* threshold. We'll be woken up again once below
* random_write_wakeup_thresh, or when the calling
* thread is about to terminate.
*/
wait_event_interruptible(random_write_wait,
kthread_should_stop() ||
ENTROPY_BITS(&input_pool) <= random_write_wakeup_bits);
}
mix_pool_bytes(poolp, buffer, count);
credit_entropy_bits(poolp, entropy);
}
Expand Down

0 comments on commit 3371f3d

Please sign in to comment.